Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSM Example #18703

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Fix CSM Example #18703

merged 1 commit into from
Feb 22, 2020

Conversation

gkjohnson
Copy link
Collaborator

It looks like #18627 wound up breaking the CSM example with changes to the lights_fragment_begins shader chunk so I've gone ahead and updated it. I've included the line breaks from the original shader chunk so it's easier to update and compare in the future.

Temporary live link:

https://raw.githack.com/gkjohnson/three.js/fix-csm/examples/webgl_shadowmap_csm.html

@vhawk

@mrdoob mrdoob added this to the r114 milestone Feb 22, 2020
@mrdoob mrdoob merged commit ddc89cf into mrdoob:dev Feb 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Feb 22, 2020

Pheww! Thanks!

@gkjohnson gkjohnson deleted the fix-csm branch February 22, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants