Examples: avoid using linear tone mapping #19712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
commented
Jun 22, 2020
| @@ -46,8 +46,7 @@ | |||
| document.body.appendChild( renderer.domElement ); | |||
|
|
|||
| // tone mapping | |||
| //renderer.toneMapping = LinearToneMapping; | |||
| //renderer.toneMappingExposure = API.exposure; | |||
| renderer.toneMapping = THREE.NoToneMapping; | |||
There was a problem hiding this comment.
Tone mapping was commented out, anyway.
WestLangley
commented
Jun 22, 2020
| @@ -40,7 +40,7 @@ | |||
| document.body.appendChild( renderer.domElement ); | |||
|
|
|||
| // tone mapping | |||
| renderer.toneMapping = THREE.LinearToneMapping; | |||
| renderer.toneMapping = THREE.ACESFilmicToneMapping; | |||
There was a problem hiding this comment.
This example supports drag-n-drop of EXR MatCap files.
WestLangley
commented
Jun 22, 2020
| @@ -195,7 +195,7 @@ | |||
| // At least one regular Pointlight is needed to activate light support | |||
| scene.add( new THREE.PointLight( 0xff0000, 0.1, 0.1 ) ); | |||
|
|
|||
| var bloom = new UnrealBloomPass( new THREE.Vector2(), 0.8, 0.6, 0.8 ); | |||
| var bloom = new UnrealBloomPass( new THREE.Vector2( window.innerWidth, window.innerHeight ), 0.8, 0.6, 0.8 ); | |||
There was a problem hiding this comment.
Unrelated, but not sure how this ever worked...
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Granted, these changes are a bit subjective, but I think
NoToneMappingis a better stub, until the example is modified to warrant a more appropriate tone mapping technique.