Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: avoid using linear tone mapping #19712

Merged
merged 1 commit into from
Jun 23, 2020
+4 −5
Merged

Examples: avoid using linear tone mapping #19712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/webgl_lightprobe.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@
document.body.appendChild( renderer.domElement );

// tone mapping
//renderer.toneMapping = LinearToneMapping;
//renderer.toneMappingExposure = API.exposure;
renderer.toneMapping = THREE.NoToneMapping;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tone mapping was commented out, anyway.


renderer.outputEncoding = THREE.sRGBEncoding;

Expand Down
2 changes: 1 addition & 1 deletion examples/webgl_materials_matcap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
document.body.appendChild( renderer.domElement );

// tone mapping
renderer.toneMapping = THREE.LinearToneMapping;
renderer.toneMapping = THREE.ACESFilmicToneMapping;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example supports drag-n-drop of EXR MatCap files.

renderer.toneMappingExposure = API.exposure;

renderer.outputEncoding = THREE.sRGBEncoding;
Expand Down
4 changes: 2 additions & 2 deletions examples/webgl_tiled_forward.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
scene.background = new THREE.Color( 0x111111 );

var renderer = new THREE.WebGLRenderer();
renderer.toneMapping = THREE.LinearToneMapping;
renderer.toneMapping = THREE.NoToneMapping;
container.appendChild( renderer.domElement );

var renderTarget = new THREE.WebGLRenderTarget();
Expand All @@ -195,7 +195,7 @@
// At least one regular Pointlight is needed to activate light support
scene.add( new THREE.PointLight( 0xff0000, 0.1, 0.1 ) );

var bloom = new UnrealBloomPass( new THREE.Vector2(), 0.8, 0.6, 0.8 );
var bloom = new UnrealBloomPass( new THREE.Vector2( window.innerWidth, window.innerHeight ), 0.8, 0.6, 0.8 );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but not sure how this ever worked...

bloom.renderToScreen = true;

var stats = new Stats();
Expand Down