Object3D: Add removeAll().

[Mugen87]

Related issues:

Fixed #20414.

Description

I like removeAll() more than the clear() since the relation to remove() is more obvious. Or in other words, it should be easier for user to figure out what removeAll() does if they are familiar with the semantics of remove().

[mrdoob]

I find clear() prettier, but now that they have added replaceAll() to Javascript... on top of what you said, following the pattern feels right.

[mrdoob]

Thanks!

[WestLangley]

removeAll(). Remove all what?

Does it remove the object? The object's children? The children of the children?

And how are they disposed?

This perhaps should be an app-level method, not a library method.

[mrdoob]

Removes all children, but doesn't traverse the hierarchy.
I've found myself needing this pretty often, but yes... the dispose situation can be confusing...

[WestLangley]

I do not think it belongs in the library. The proper implementation is app-specific.

But at a minimum, I think the name should be changed to something else.

[Mugen87]

Then we should probably change remove() to removeChild(), too. Or event to removeChildButNotChildrenOfChild()...

TBH, I think the name (and the method itself) is totally fine. Improving the documentation to provide more clarity is of course always a good idea.

[mrdoob]

But at a minimum, I think the name should be changed to something else.

Neither Mugen87 nor I are native english speakers. Any help with naming is always welcome 🙏

[mrdoob]

I'm going to go with .clear() which is what I used in ui.js.

[mrdoob]

315d0fc

[mrdoob]

Interesting, this conflicts with CubeCamera:
https://github.com/mrdoob/three.js/blob/dev/src/cameras/CubeCamera.js#L97-L111

[Mugen87]

This also breaks the TS build:

src/cameras/CubeCamera.d.ts(16,2): error TS2416: Property 'clear' in type 'CubeCamera' is not assignable to the same property in base type 'Object3D'.

[mrdoob]

Yep, I'll think about this.