Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometryUtils: Add toCreasedNormals(). #23989

Merged
merged 4 commits into from
Oct 30, 2022

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented May 1, 2022

Related issue: #3670

Description

Adds a function to generate a new, non-indexed geometry with smooth normals for edges where the faces are within the provided angle threshold.

Also related: https://discourse.threejs.org/t/is-there-a-merge-vertices-smooth-normals-utility-with-a-crease-angle-argument-available/37679

Original Merge + Smooth Smooth w/ Crease Angle
image image image

@gkjohnson gkjohnson added this to the r141 milestone May 17, 2022
@mrdoob mrdoob modified the milestones: r141, r142 May 26, 2022
@mrdoob mrdoob modified the milestones: r142, r143 Jun 29, 2022
@mrdoob mrdoob modified the milestones: r143, r144 Jul 28, 2022
@mrdoob mrdoob modified the milestones: r144, r145 Aug 31, 2022
@mrdoob mrdoob modified the milestones: r145, r146 Sep 29, 2022
@mrdoob mrdoob modified the milestones: r146, r147 Oct 27, 2022
@Mugen87 Mugen87 merged commit c7afd83 into mrdoob:dev Oct 30, 2022
@Mugen87 Mugen87 changed the title BufferGeometryUtils: Add function to generate smooth normal geometry with crease angle BufferGeometryUtils: Add toCreasedNormals(). Oct 30, 2022
@gkjohnson gkjohnson deleted the creased-normals branch October 30, 2022 19:42
@joshuaellis joshuaellis mentioned this pull request Oct 31, 2022
12 tasks
0b5vr added a commit to three-types/three-ts-types that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants