Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r147 #276

Closed
12 tasks done
joshuaellis opened this issue Oct 31, 2022 · 8 comments
Closed
12 tasks done

r147 #276

joshuaellis opened this issue Oct 31, 2022 · 8 comments
Labels
new release issues to do with the upcoming release of Three

Comments

@joshuaellis
Copy link
Member

joshuaellis commented Oct 31, 2022

Issue Tracker

This is used to track potential issues we need to investigate surrounding the r147 release.

Core

Addons

Last checked: mrdoob/three.js@r147.

@joshuaellis joshuaellis added the new release issues to do with the upcoming release of Three label Oct 31, 2022
@joshuaellis joshuaellis pinned this issue Oct 31, 2022
@0b5vr
Copy link
Contributor

0b5vr commented Dec 7, 2022

Content already applied to the issue tracker https://github.com/mrdoob/three.js/releases/tag/r147

Core

Addons


Tried to be exhaustive but I might am missing something

@joshuaellis
Copy link
Member Author

@0b5vr, i've added you as a maintainer so you can update comments etc. due to how helpful you've been here :)

@0b5vr
Copy link
Contributor

0b5vr commented Dec 7, 2022

woooo, updating the issue

I'm sorry that I couldn't check updates in these days 😇 will try to help as much as I can

@LuchoTurtle
Copy link
Contributor

LuchoTurtle commented Dec 18, 2022

Hey guys, thanks for the repo!
One of the steps in the r147 migration guide regards the PixelShader removal and replacement with the RenderPixelatedPass inside postprocessing.
I know this is not a priority but I already created an issue #301 and a PR to be merged #302.
I think it's related with this release 😄

@0b5vr
Copy link
Contributor

0b5vr commented Dec 19, 2022

added the RenderPixelatedPass checkbox on the issue

@0b5vr 0b5vr mentioned this issue Dec 19, 2022
3 tasks
@0b5vr
Copy link
Contributor

0b5vr commented Dec 19, 2022

@joshuaellis prioritizing speed, I'll do all the changes on r147 branch.

#303

@0b5vr
Copy link
Contributor

0b5vr commented Dec 20, 2022

oof, I was not aware of separated PRs (#290, #291). I'll be careful next time.

@joshuaellis
Copy link
Member Author

will be resolved by DefinitelyTyped/DefinitelyTyped#63676 (review)

@joshuaellis joshuaellis unpinned this issue Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new release issues to do with the upcoming release of Three
Projects
None yet
Development

No branches or pull requests

3 participants