Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RenderPixelatedPass #301

Closed
LuchoTurtle opened this issue Dec 18, 2022 · 1 comment · Fixed by #302
Closed

Add RenderPixelatedPass #301

LuchoTurtle opened this issue Dec 18, 2022 · 1 comment · Fixed by #302
Labels
enhancement New feature or request

Comments

@LuchoTurtle
Copy link
Contributor

Describe the feature you'd like:

As per r147 migration guide, PixelShader was replaced with RenderPixelatedPass inside the jsm/examples folder. I think we should add types for this new pass. 😄

Suggested implementation:

Adding the class types should be helpful for those who want to use this composer pass.
I can make a quick PR to fix this for the r147 release.
@LuchoTurtle LuchoTurtle added the enhancement New feature or request label Dec 18, 2022
@LuchoTurtle
Copy link
Contributor Author

I can create a quick PR to fix this 👍

LuchoTurtle added a commit to LuchoTurtle/three-ts-types that referenced this issue Dec 18, 2022
@LuchoTurtle
feat: Adding RenderPixelatedPass types. three-types#301
c3db151
LuchoTurtle added a commit to LuchoTurtle/three-ts-types that referenced this issue Dec 18, 2022
@LuchoTurtle
fix: Deleting PixelShader and replacing it in other_files.txt. thre…
fe15beb 
…e-types#301
LuchoTurtle added a commit to LuchoTurtle/three-ts-types that referenced this issue Dec 18, 2022
@LuchoTurtle
fix: Adding contributor. three-types#301
e29da7c
This was referenced Dec 18, 2022
Merged
Closed
LuchoTurtle added a commit to LuchoTurtle/three-ts-types that referenced this issue Dec 18, 2022
@LuchoTurtle
fix: Fixing other_files RenderPixelatedPass declaration. three-type…
e895131 
…s#301
LuchoTurtle added a commit to LuchoTurtle/three-ts-types that referenced this issue Dec 19, 2022
@LuchoTurtle
fix: Adding type to fsquad. three-types#301
05af4d0
0b5vr pushed a commit that referenced this issue Dec 19, 2022
@LuchoTurtle
[feat] Adding RenderPixelatedPass types. (#302)
db5181a 
* feat: Adding RenderPixelatedPass types. #301

* fix: Deleting PixelShader and replacing it in `other_files.txt`. #301

* fix: Adding contributor. #301

* fix: Fixing `other_files` RenderPixelatedPass declaration. #301

* fix: Adding type to fsquad. #301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feat] Adding RenderPixelatedPass types. LuchoTurtle/three-ts-types
1 participant
@LuchoTurtle