Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples > Add VFX flames #28969

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Examples > Add VFX flames #28969

merged 1 commit into from
Jul 25, 2024

Conversation

brunosimon
Copy link
Contributor

Description

Add WebGPU/TSL VFX flames example, along with two textures in the examples/textures/noises/ folder.
VFX inspired by @cmzw_
I added the screenshot to the exceptions since I can't generate one that works with the tests.

localhost_8083_examples_webgpu_tsl_vfx_flames html

@sunag sunag added this to the r168 milestone Jul 25, 2024
@sunag
Copy link
Collaborator

sunag commented Jul 25, 2024

There is an artifact being generated because of pow() on Windows #28955 (comment), I will merge it up and submit a fix soon.

image

@sunag sunag merged commit 30a0288 into mrdoob:dev Jul 25, 2024
11 checks passed
@WestLangley
Copy link
Collaborator

How about it we emulate a sprite and add this in the render loop:

flame1.lookAt( camera.position );
flame2.lookAt( camera.position );

@brunosimon
Copy link
Contributor Author

How about it we emulate a sprite and add this in the render loop:

flame1.lookAt( camera.position );
flame2.lookAt( camera.position );

It's a good idea, but I actually kept it like this on purpose so that the user notice that it's a simple plane.

@WestLangley
Copy link
Collaborator

I hear you, but it is not going to be used that way. I think the example should show how to use it properly.

I wonder if it could be implemented as a sprite with a pivot point at the bottom-center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants