Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Add spherizeUV #28976

Merged
merged 2 commits into from
Jul 26, 2024
Merged

TSL: Add spherizeUV #28976

merged 2 commits into from
Jul 26, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 26, 2024

Related issue: #28969

Description

I fork spherizeUV() of @brunosimon example and I changed the function signature, it is common for the central value to be vec2( .5 ) so this is optional, offset can be performed outside of spherize.

@sunag sunag added this to the r168 milestone Jul 26, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag marked this pull request as ready for review July 26, 2024 05:14
@sunag sunag merged commit 4cc8fdf into mrdoob:dev Jul 26, 2024
12 checks passed
@sunag sunag deleted the dev-uvutils branch July 26, 2024 06:33
brunosimon pushed a commit to brunosimon/three.js that referenced this pull request Jul 28, 2024
* TSL: Add `spherizeUV`

* update imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant