Fix unsupported top level event type #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is so weird 😂 |
mrousavy
reviewed
Nov 4, 2024
| @@ -23,7 +23,7 @@ internal class LoadStartEvent( | |||
| override fun getEventData(): WritableMap = Arguments.createMap() | |||
|
|
|||
| companion object { | |||
| const val EVENT_NAME = "topBlurhashLoadStart" | |||
| const val EVENT_NAME = "topLoadStart" | |||
There was a problem hiding this comment.
Can topLoadStart theoretically collide with other components that emit events under the same name, like e.g. an Image component?
There was a problem hiding this comment.
That is also what I was wondering, but seems to work fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the even name has to match now in RN 0.76 on new arch, so onLoadStart needs to be topLoadStart instead of topBlurhashLoadStart.
Fix #199