Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported top level event type #200

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix unsupported top level event type #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/src/main/java/com/mrousavy/blurhash/BlurhashViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ internal class LoadStartEvent(
override fun getEventData(): WritableMap = Arguments.createMap()

companion object {
const val EVENT_NAME = "topBlurhashLoadStart"
const val EVENT_NAME = "topLoadStart"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can topLoadStart theoretically collide with other components that emit events under the same name, like e.g. an Image component?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is also what I was wondering, but seems to work fine

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool lgtm then haha thx

}
}

Expand All @@ -36,7 +36,7 @@ internal class LoadEndEvent(
override fun getEventData(): WritableMap = Arguments.createMap()

companion object {
const val EVENT_NAME = "topBlurhashLoadEnd"
const val EVENT_NAME = "topLoadEnd"
}
}

Expand All @@ -51,7 +51,7 @@ internal class LoadErrorEvent(
Arguments.createMap().apply { putString("message", message) }

companion object {
const val EVENT_NAME = "topBlurhashLoadError"
const val EVENT_NAME = "topLoadError"
}
}

Expand Down
Loading