Fix scroll position getting reset after config changes #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why I decided to do it in on lifecycle on create. That ended up calling this `init` every time home screen presenter is created. Which means the paging cache is not used. Instead we are using the presenter instance class init to trigger subscribing to cached paging flow which fixes the scroll position getting reset of config changes. Weirdly it doesn't fix scroll position getting reset for navigation. Will have to check separately and resolve it in a different PR.
msasikanth
deleted the
sm/02feb/fix-scroll-position-reset-config-change
branch
|
Hi masasikanth, Regarding the comment "...Weirdly it doesn't fix scroll position getting reset for navigation. Will have to check separately and resolve it in a different PR." Can I ask which PR is it? Thanks a lot! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #271