Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scroll position getting reset after config changes #273

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix scroll position getting reset after config changes #273

merged 1 commit into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. Call HomeScreen.Init when HomePresenterInstanse class init happens 

    I don't know why I decided to do it in on lifecycle on create. That ended up calling this `init` every time home screen presenter is created. Which means the paging cache is not used. Instead we are using the presenter instance class init to trigger subscribing to cached paging flow which fixes the scroll position getting reset of config changes. Weirdly it doesn't fix scroll position getting reset for navigation. Will have to check separately and resolve it in a different PR.
    @msasikanth
    msasikanth committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    a211741 View commit details
    Browse the repository at this point in the history