Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename file to avoid codesign bug on macos catalina #143

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Strangerxxx
Copy link

No description provided.

@mscdex
Copy link
Owner

mscdex commented Feb 19, 2020

Can you explain what the problem is exactly? The UTF-8 filename exists for a reason.

@Strangerxxx
Copy link
Author

Strangerxxx commented Feb 23, 2020

Every time I built electron app using electron-builder, including mmmagic node module and sign code using latest macos catalina software and notaize it, I get an error for the file, renamed in this PR
See screenshot for error information
console

@mscdex
Copy link
Owner

mscdex commented Feb 23, 2020

This seems to be specifically a macOS filesystem issue. Have you tried solutions such as this as a workaround?

It may be worth posting an issue on the electron-builder issue tracker about this as they may be able to incorporate appropriate fixes/workarounds for macOS.

@Strangerxxx
Copy link
Author

Strangerxxx commented Feb 23, 2020

No, didn't tried that yet. It means that the files, which are going to be packed should be converted their names to unicode nfd, am I right?
So if I use cross platform build on mac then it will fail if I try to run the app on other systems with nfc unicode mode.
In this case all the files should be converted back to pack for other systems.
So why not just to stop using diacritics in filenames? Or it's more like a test of this unicode case?

@mscdex
Copy link
Owner

mscdex commented Feb 24, 2020

The point of the utf-8 filename is specifically to test a workaround that was added for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants