-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device tree for ASUS ZenPad 8.0 #285
base: msm8916/6.2-rc5
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are suggested. Please have a look.
Consider joining #msm8916:postmarketos.org for discussions. |
1e8e19d
to
a6e6799
Compare
Looks much better. There are something to do about the commit messages: Just a note. It's not clear whether we should apply the following changes: |
The |
@wonderfulShrineMaidenOfParadise can't understand what not good in signoff now... :( |
The current one is valid and looks good.
Did you add it? I don't see any vibrator in the device tree. |
No. Vibration at poweron misled me. |
ASUS ZenPad 8.0 is a tablet using the MSM8916 SoC. Add device tree with initial support for: - SDHCI (internal and external storage) - USB Device Mode - UART - Regulators - WiFi/BT - Volume buttons This device tree is based on downstream device tree from ASUS. Signed-off-by: Vasiliy Borisov <vasy@vasy.ru>
This device has battery and smb345 charger ic. Add support for it. Signed-off-by: Vasiliy Borisov <vasy@vasy.ru>
Add support for Modem and Sound in ASUS ZenPad 8.0. Signed-off-by: Vasiliy Borisov <vasy@vasy.ru>
regulator-min-microvolt = <2950000>; | ||
regulator-max-microvolt = <2950000>; | ||
|
||
gpio = <&msmgpio 87 GPIO_ACTIVE_HIGH>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, have you tested if SD card is working? It looks like you copied this from z00l (which is fine), but the downstream device tree I'm looking at seems to specify 119.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, untested. :( I will look it.
&pronto { | ||
status = "okay"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note about new changes since 6.3+: 3244442
No description provided.