Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device tree for ASUS ZenPad 8.0 #285

Draft
wants to merge 3 commits into
base: msm8916/6.2-rc5
Choose a base branch
from
Draft

Add device tree for ASUS ZenPad 8.0 #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
858f0ce
arm64: dts: qcom: Add device tree for ASUS ZenPad 8.0
vm03 Oct 19, 2022
8e2bc56
arm64: dts: qcom: p024: add battery and charger
vm03 Oct 20, 2022
f563533
arm64: dts: qcom: p024: add sound and modem
vm03 Feb 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions arch/arm64/boot/dts/qcom/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-alto5-vdf.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-ark-peach.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-asus-p024.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-asus-z00l.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-asus-z010d.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-gplus-fl8005a.dtb
Expand Down
290 changes: 290 additions & 0 deletions arch/arm64/boot/dts/qcom/msm8916-asus-p024.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,290 @@
// SPDX-License-Identifier: GPL-2.0-only

/dts-v1/;

#include "msm8916-pm8916.dtsi"
#include "msm8916-modem.dtsi"
stephan-gh marked this conversation as resolved.
Show resolved Hide resolved

#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/power/summit,smb347-charger.h>

/ {
model = "ASUS ZenPad 8.0";
compatible = "asus,p024", "qcom,msm8916";
chassis-type = "tablet";

aliases {
serial0 = &blsp1_uart2;
};

chosen {
stdout-path = "serial0";
};

reserved-memory {
mpss_mem: mpss@86800000 {
reg = <0x0 0x86800000 0x0 0x5500000>;
no-map;
};

gps_mem: gps@8bd00000 {
reg = <0x0 0x8bd00000 0x0 0x200000>;
no-map;
};
};

bat: battery {
compatible = "simple-battery";
voltage-min-design-microvolt = <3400000>;
voltage-max-design-microvolt = <4350000>;
energy-full-design-microwatt-hours = <15200000>;
charge-full-design-microamp-hours = <3800000>;

ocv-capacity-celsius = <25>;
ocv-capacity-table-0 = <4331000 100>, <4261000 95>, <4204000 90>,
<4152000 85>, <4102000 80>, <4060000 75>, <3998000 70>,
<3964000 65>, <3924000 60>, <3874000 55>, <3842000 50>,
<3820000 45>, <3800000 40>, <3785000 35>, <3720000 30>,
<3758000 25>, <3735000 20>, <3706000 16>, <3690000 13>,
<3687000 11>, <3686000 10>, <3684000 9>, <3680000 8>,
<3668000 7>, <3640000 6>, <3596000 5>, <3542000 4>,
<3472000 3>, <3378000 2>, <3239000 1>, <3000000 0>;
};

gpio-keys {
compatible = "gpio-keys";

pinctrl-names = "default";
pinctrl-0 = <&gpio_keys_default>;

label = "GPIO Buttons";

button-volume-up {
label = "Volume Up";
gpios = <&msmgpio 107 GPIO_ACTIVE_LOW>;
linux,code = <KEY_VOLUMEUP>;
debounce-interval = <15>;
};
};

reg_sd_vmmc: regulator-sdcard-vmmc {
compatible = "regulator-fixed";
regulator-name = "sdcard-vmmc";
regulator-min-microvolt = <2950000>;
regulator-max-microvolt = <2950000>;

gpio = <&msmgpio 87 GPIO_ACTIVE_HIGH>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, have you tested if SD card is working? It looks like you copied this from z00l (which is fine), but the downstream device tree I'm looking at seems to specify 119.

https://github.com/msm8916-mainline/linux-downstream/blob/asus-p024/arch/arm/boot/dts/qcom/msm8916-mtp-Z380KL.dts#L236

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, untested. :( I will look it.

enable-active-high;

startup-delay-us = <200>;

pinctrl-names = "default";
pinctrl-0 = <&sd_vmmc_en_default>;
};

usb_id: usb-id {
compatible = "linux,extcon-usb-gpio";
id-gpios = <&msmgpio 110 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&usb_id_default>;
};
};

&blsp_i2c4 {
status = "okay";

charger@6a {
compatible = "summit,smb345";
reg = <0x6a>;

summit,enable-charge-control = <SMB3XX_CHG_ENABLE_SW>;
summit,chip-temperature-threshold-celsius = <110>;
summit,usb-current-limit-microamp = <500000>;
summit,enable-usb-charging;
summit,enable-otg-charging;
};
};

&blsp1_uart2 {
status = "okay";
};

&pronto {
status = "okay";
};
Comment on lines +114 to +116
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note about new changes since 6.3+: 3244442


&pm8916_bms {
monitored-battery = <&bat>;
status = "okay";
};

&sdhc_1 {
pinctrl-names = "default", "sleep";
pinctrl-0 = <&sdc1_clk_on &sdc1_cmd_on &sdc1_data_on>;
pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off>;

status = "okay";
};

&sdhc_2 {
vmmc-supply = <&reg_sd_vmmc>;

pinctrl-names = "default", "sleep";
pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>;
cd-gpios = <&msmgpio 38 GPIO_ACTIVE_LOW>;

status = "okay";
};

&sound {
status = "okay";
};

&usb {
extcon = <&usb_id>, <&usb_id>;
status = "okay";
};

&usb_hs_phy {
extcon = <&usb_id>;
};

&wcd_codec {
qcom,micbias-lvl = <2800>;
qcom,mbhc-vthreshold-low = <75 150 237 450 500>;
qcom,mbhc-vthreshold-high = <75 150 237 450 500>;
qcom,micbias1-ext-cap;
qcom,hphl-jack-type-normally-open;
};

&smd_rpm_regulators {
vdd_l1_l2_l3-supply = <&pm8916_s3>;
vdd_l4_l5_l6-supply = <&pm8916_s4>;
vdd_l7-supply = <&pm8916_s4>;

s3 {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1300000>;
};

s4 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <2100000>;
};

l1 {
regulator-min-microvolt = <1225000>;
regulator-max-microvolt = <1225000>;
};

l2 {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
};

l4 {
regulator-min-microvolt = <2050000>;
regulator-max-microvolt = <2050000>;
};

l5 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
};

l6 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
};

l7 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
};

l8 {
regulator-min-microvolt = <2850000>;
regulator-max-microvolt = <2900000>;
};

l9 {
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
};

l10 {
regulator-min-microvolt = <2700000>;
regulator-max-microvolt = <2800000>;
};

l11 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <2950000>;
regulator-allow-set-load;
regulator-system-load = <200000>;
};

l12 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <2950000>;
};

l13 {
regulator-min-microvolt = <3075000>;
regulator-max-microvolt = <3075000>;
};

l14 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
};

l15 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
};

l16 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
};

l17 {
regulator-min-microvolt = <2850000>;
regulator-max-microvolt = <2850000>;
};

l18 {
regulator-min-microvolt = <2700000>;
regulator-max-microvolt = <2700000>;
};
};

&msmgpio {
gpio_keys_default: gpio-keys-default-state {
pins = "gpio107", "gpio117";
function = "gpio";

drive-strength = <2>;
bias-pull-up;
};

sd_vmmc_en_default: sd-vmmc-en-default-state {
pins = "gpio87";
function = "gpio";

drive-strength = <2>;
bias-disable;
};

usb_id_default: usb-id-default-state {
pins = "gpio110";
function = "gpio";

drive-strength = <8>;
bias-pull-up;
};
};