Skip to content

Commit

Permalink
[Cache] Truly disable loading the RFS cache (sonic-net#19395)
Browse files Browse the repository at this point in the history
Why I did it
Bug Fix: RFS is still loading from cache

user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log
Build start time: Tue Jun 25 20:13:00 UTC 2024
[ FLAGS  FILE   ] : [mellanox amd64 bookworm]
[ FLAGS  DEPENDS ] : [mellanox amd64 bookworm]
[ FLAGS  DIFF   ] : []
target/sonic-mellanox.bin__mellanox__rfs.squashfs
target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is loaded from cache into /sonic
[ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is not present in cache or cache mode set as cache !
[ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
[ CACHE::SKIPPED ] DEP_FILES - Modified Files: []
[ CACHE::SKIPPED ] DEPENDS   - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep]
Build end time: Tue Jun 25 20:13:04 UTC 2024
Elapsed time: 0h 0m 4s

- How I did it
Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE

- How to verify it
Re-trigger the RFS and see it being built and not getting loaded from cache

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
  • Loading branch information
vivekrnv authored and mssonicbld committed Jul 25, 2024
1 parent 4cb16d7 commit 5e5e54e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion slave.mk
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,7 @@ $(addprefix $(TARGET_PATH)/, $(SONIC_RFS_TARGETS)) : $(TARGET_PATH)/% : \
$(call dpkg_depend,$(TARGET_PATH)/%.dep)
$(HEADER)

# $(call LOAD_CACHE,$*,$@)
# $(call LOAD_CACHE,$*,$@)

# Skip building the target if it is already loaded from cache
if [ -z '$($*_CACHE_LOADED)' ] ; then
Expand Down

0 comments on commit 5e5e54e

Please sign in to comment.