-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cache] Truly disable loading the RFS cache #19395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
approved these changes
Jun 26, 2024
oleksandrivantsiv
approved these changes
Jun 26, 2024
@liat-grozovik @lguohan Can you please help merge this? |
liat-grozovik
approved these changes
Jul 1, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 25, 2024
Why I did it Bug Fix: RFS is still loading from cache user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log Build start time: Tue Jun 25 20:13:00 UTC 2024 [ FLAGS FILE ] : [mellanox amd64 bookworm] [ FLAGS DEPENDS ] : [mellanox amd64 bookworm] [ FLAGS DIFF ] : [] target/sonic-mellanox.bin__mellanox__rfs.squashfs target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is loaded from cache into /sonic [ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is not present in cache or cache mode set as cache ! [ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz [ CACHE::SKIPPED ] DEP_FILES - Modified Files: [] [ CACHE::SKIPPED ] DEPENDS - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep] Build end time: Tue Jun 25 20:13:04 UTC 2024 Elapsed time: 0h 0m 4s - How I did it Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE - How to verify it Re-trigger the RFS and see it being built and not getting loaded from cache Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Cherry-pick PR to 202405: #19691 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 25, 2024
Why I did it Bug Fix: RFS is still loading from cache user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log Build start time: Tue Jun 25 20:13:00 UTC 2024 [ FLAGS FILE ] : [mellanox amd64 bookworm] [ FLAGS DEPENDS ] : [mellanox amd64 bookworm] [ FLAGS DIFF ] : [] target/sonic-mellanox.bin__mellanox__rfs.squashfs target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is loaded from cache into /sonic [ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is not present in cache or cache mode set as cache ! [ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz [ CACHE::SKIPPED ] DEP_FILES - Modified Files: [] [ CACHE::SKIPPED ] DEPENDS - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep] Build end time: Tue Jun 25 20:13:04 UTC 2024 Elapsed time: 0h 0m 4s - How I did it Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE - How to verify it Re-trigger the RFS and see it being built and not getting loaded from cache Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Cherry-pick PR to 202311: #19692 |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 25, 2024
Why I did it Bug Fix: RFS is still loading from cache user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log Build start time: Tue Jun 25 20:13:00 UTC 2024 [ FLAGS FILE ] : [mellanox amd64 bookworm] [ FLAGS DEPENDS ] : [mellanox amd64 bookworm] [ FLAGS DIFF ] : [] target/sonic-mellanox.bin__mellanox__rfs.squashfs target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is loaded from cache into /sonic [ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is not present in cache or cache mode set as cache ! [ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz [ CACHE::SKIPPED ] DEP_FILES - Modified Files: [] [ CACHE::SKIPPED ] DEPENDS - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep] Build end time: Tue Jun 25 20:13:04 UTC 2024 Elapsed time: 0h 0m 4s - How I did it Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE - How to verify it Re-trigger the RFS and see it being built and not getting loaded from cache Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Jul 25, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Jul 26, 2024
Why I did it Bug Fix: RFS is still loading from cache user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log Build start time: Tue Jun 25 20:13:00 UTC 2024 [ FLAGS FILE ] : [mellanox amd64 bookworm] [ FLAGS DEPENDS ] : [mellanox amd64 bookworm] [ FLAGS DIFF ] : [] target/sonic-mellanox.bin__mellanox__rfs.squashfs target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is loaded from cache into /sonic [ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is not present in cache or cache mode set as cache ! [ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz [ CACHE::SKIPPED ] DEP_FILES - Modified Files: [] [ CACHE::SKIPPED ] DEPENDS - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep] Build end time: Tue Jun 25 20:13:04 UTC 2024 Elapsed time: 0h 0m 4s - How I did it Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE - How to verify it Re-trigger the RFS and see it being built and not getting loaded from cache Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Jul 26, 2024
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
Why I did it Bug Fix: RFS is still loading from cache user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log Build start time: Tue Jun 25 20:13:00 UTC 2024 [ FLAGS FILE ] : [mellanox amd64 bookworm] [ FLAGS DEPENDS ] : [mellanox amd64 bookworm] [ FLAGS DIFF ] : [] target/sonic-mellanox.bin__mellanox__rfs.squashfs target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is loaded from cache into /sonic [ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is not present in cache or cache mode set as cache ! [ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz [ CACHE::SKIPPED ] DEP_FILES - Modified Files: [] [ CACHE::SKIPPED ] DEPENDS - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep] Build end time: Tue Jun 25 20:13:04 UTC 2024 Elapsed time: 0h 0m 4s - How I did it Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE - How to verify it Re-trigger the RFS and see it being built and not getting loaded from cache Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
Why I did it Bug Fix: RFS is still loading from cache user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log Build start time: Tue Jun 25 20:13:00 UTC 2024 [ FLAGS FILE ] : [mellanox amd64 bookworm] [ FLAGS DEPENDS ] : [mellanox amd64 bookworm] [ FLAGS DIFF ] : [] target/sonic-mellanox.bin__mellanox__rfs.squashfs target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is loaded from cache into /sonic [ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is not present in cache or cache mode set as cache ! [ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz [ CACHE::SKIPPED ] DEP_FILES - Modified Files: [] [ CACHE::SKIPPED ] DEPENDS - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep] Build end time: Tue Jun 25 20:13:04 UTC 2024 Elapsed time: 0h 0m 4s - How I did it Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE - How to verify it Re-trigger the RFS and see it being built and not getting loaded from cache Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Bug Fix: RFS is still loading from cache
Work item tracking
How I did it
Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE
How to verify it
Re-trigger the RFS and see it being built and not getting loaded from cache
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)