Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Truly disable loading the RFS cache #19395

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

vivekrnv
Copy link
Contributor

Why I did it

Bug Fix: RFS is still loading from cache

user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log
Build start time: Tue Jun 25 20:13:00 UTC 2024
[ FLAGS  FILE   ] : [mellanox amd64 bookworm]
[ FLAGS  DEPENDS ] : [mellanox amd64 bookworm]
[ FLAGS  DIFF   ] : []
target/sonic-mellanox.bin__mellanox__rfs.squashfs
target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is loaded from cache into /sonic
[ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is not present in cache or cache mode set as cache !
[ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
[ CACHE::SKIPPED ] DEP_FILES - Modified Files: []
[ CACHE::SKIPPED ] DEPENDS   - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep]
Build end time: Tue Jun 25 20:13:04 UTC 2024
Elapsed time: 0h 0m 4s
Work item tracking
  • Microsoft ADO (number only):

How I did it

Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE

How to verify it

Re-trigger the RFS and see it being built and not getting loaded from cache

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgsudharsan
Copy link
Collaborator

@liat-grozovik @lguohan Can you please help merge this?

@liat-grozovik liat-grozovik merged commit 5302599 into sonic-net:master Jul 1, 2024
20 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jul 25, 2024
Why I did it
Bug Fix: RFS is still loading from cache

user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log
Build start time: Tue Jun 25 20:13:00 UTC 2024
[ FLAGS  FILE   ] : [mellanox amd64 bookworm]
[ FLAGS  DEPENDS ] : [mellanox amd64 bookworm]
[ FLAGS  DIFF   ] : []
target/sonic-mellanox.bin__mellanox__rfs.squashfs
target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is loaded from cache into /sonic
[ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is not present in cache or cache mode set as cache !
[ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
[ CACHE::SKIPPED ] DEP_FILES - Modified Files: []
[ CACHE::SKIPPED ] DEPENDS   - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep]
Build end time: Tue Jun 25 20:13:04 UTC 2024
Elapsed time: 0h 0m 4s

- How I did it
Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE

- How to verify it
Re-trigger the RFS and see it being built and not getting loaded from cache

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19691

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jul 25, 2024
Why I did it
Bug Fix: RFS is still loading from cache

user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log
Build start time: Tue Jun 25 20:13:00 UTC 2024
[ FLAGS  FILE   ] : [mellanox amd64 bookworm]
[ FLAGS  DEPENDS ] : [mellanox amd64 bookworm]
[ FLAGS  DIFF   ] : []
target/sonic-mellanox.bin__mellanox__rfs.squashfs
target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is loaded from cache into /sonic
[ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is not present in cache or cache mode set as cache !
[ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
[ CACHE::SKIPPED ] DEP_FILES - Modified Files: []
[ CACHE::SKIPPED ] DEPENDS   - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep]
Build end time: Tue Jun 25 20:13:04 UTC 2024
Elapsed time: 0h 0m 4s

- How I did it
Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE

- How to verify it
Re-trigger the RFS and see it being built and not getting loaded from cache

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #19692

mssonicbld pushed a commit that referenced this pull request Jul 25, 2024
Why I did it
Bug Fix: RFS is still loading from cache

user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log
Build start time: Tue Jun 25 20:13:00 UTC 2024
[ FLAGS  FILE   ] : [mellanox amd64 bookworm]
[ FLAGS  DEPENDS ] : [mellanox amd64 bookworm]
[ FLAGS  DIFF   ] : []
target/sonic-mellanox.bin__mellanox__rfs.squashfs
target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is loaded from cache into /sonic
[ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is not present in cache or cache mode set as cache !
[ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
[ CACHE::SKIPPED ] DEP_FILES - Modified Files: []
[ CACHE::SKIPPED ] DEPENDS   - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep]
Build end time: Tue Jun 25 20:13:04 UTC 2024
Elapsed time: 0h 0m 4s

- How I did it
Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE

- How to verify it
Re-trigger the RFS and see it being built and not getting loaded from cache

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
mssonicbld pushed a commit that referenced this pull request Jul 26, 2024
Why I did it
Bug Fix: RFS is still loading from cache

user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log
Build start time: Tue Jun 25 20:13:00 UTC 2024
[ FLAGS  FILE   ] : [mellanox amd64 bookworm]
[ FLAGS  DEPENDS ] : [mellanox amd64 bookworm]
[ FLAGS  DIFF   ] : []
target/sonic-mellanox.bin__mellanox__rfs.squashfs
target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is loaded from cache into /sonic
[ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is not present in cache or cache mode set as cache !
[ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
[ CACHE::SKIPPED ] DEP_FILES - Modified Files: []
[ CACHE::SKIPPED ] DEPENDS   - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep]
Build end time: Tue Jun 25 20:13:04 UTC 2024
Elapsed time: 0h 0m 4s

- How I did it
Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE

- How to verify it
Re-trigger the RFS and see it being built and not getting loaded from cache

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
Why I did it
Bug Fix: RFS is still loading from cache

user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log
Build start time: Tue Jun 25 20:13:00 UTC 2024
[ FLAGS  FILE   ] : [mellanox amd64 bookworm]
[ FLAGS  DEPENDS ] : [mellanox amd64 bookworm]
[ FLAGS  DIFF   ] : []
target/sonic-mellanox.bin__mellanox__rfs.squashfs
target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is loaded from cache into /sonic
[ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is not present in cache or cache mode set as cache !
[ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
[ CACHE::SKIPPED ] DEP_FILES - Modified Files: []
[ CACHE::SKIPPED ] DEPENDS   - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep]
Build end time: Tue Jun 25 20:13:04 UTC 2024
Elapsed time: 0h 0m 4s

- How I did it
Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE

- How to verify it
Re-trigger the RFS and see it being built and not getting loaded from cache

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
Why I did it
Bug Fix: RFS is still loading from cache

user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log
Build start time: Tue Jun 25 20:13:00 UTC 2024
[ FLAGS  FILE   ] : [mellanox amd64 bookworm]
[ FLAGS  DEPENDS ] : [mellanox amd64 bookworm]
[ FLAGS  DIFF   ] : []
target/sonic-mellanox.bin__mellanox__rfs.squashfs
target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is loaded from cache into /sonic
[ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz  is not present in cache or cache mode set as cache !
[ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz
[ CACHE::SKIPPED ] DEP_FILES - Modified Files: []
[ CACHE::SKIPPED ] DEPENDS   - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep]
Build end time: Tue Jun 25 20:13:04 UTC 2024
Elapsed time: 0h 0m 4s

- How I did it
Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE

- How to verify it
Re-trigger the RFS and see it being built and not getting loaded from cache

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants