Skip to content

Commit

Permalink
Added safe reload=True option for config reload performed in syslog_r…
Browse files Browse the repository at this point in the history
…ate_limit to eliminate intermittent failures (sonic-net#16682)

This PR addresses an issue where the syslog rate_limit configuration command does not take effect properly because certain containers are not fully initialized before the command execution. To resolve this, "safe reload" option has been added to the config reload. This ensures that all containers and critical processes are up and running before the configuration is applied, ensuring successful configuration

What is the motivation for this PR?
Fix intermittent failure caused by containers not up before rate_limit config command execution

How did you do it?
Added safe=True option to config reload

How did you verify/test it?
Run test_syslog_rate_limit testcase on Nokia-7215 platforms

Co-authored-by: karavasi <olympia.karavasili_arapogianni@nokia.com>
  • Loading branch information
2 people authored and mssonicbld committed Feb 8, 2025
1 parent ff1ca2c commit 26180e6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/syslog/test_syslog_rate_limit.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def test_syslog_rate_limit(rand_selected_dut):
# Save configuration and reload, verify the configuration can be loaded
logger.info('Persist syslog rate limit configuration to DB and do config reload')
rand_selected_dut.command('config save -y')
config_reload(rand_selected_dut)
config_reload(rand_selected_dut, safe_reload=True)

# database does not support syslog rate limit configuration persist
verify_container_rate_limit(rand_selected_dut, ignore_containers=['database'])
Expand Down

0 comments on commit 26180e6

Please sign in to comment.