Added safe reload=True option for config reload performed in syslog_rate_limit to eliminate intermittent failures #16682
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Blueve @lizhijianrd Please help review and merge |
lizhijianrd
approved these changes
Feb 8, 2025
Blueve
approved these changes
Feb 8, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 8, 2025
…ate_limit to eliminate intermittent failures (sonic-net#16682) This PR addresses an issue where the syslog rate_limit configuration command does not take effect properly because certain containers are not fully initialized before the command execution. To resolve this, "safe reload" option has been added to the config reload. This ensures that all containers and critical processes are up and running before the configuration is applied, ensuring successful configuration What is the motivation for this PR? Fix intermittent failure caused by containers not up before rate_limit config command execution How did you do it? Added safe=True option to config reload How did you verify/test it? Run test_syslog_rate_limit testcase on Nokia-7215 platforms Co-authored-by: karavasi <olympia.karavasili_arapogianni@nokia.com>
|
Cherry-pick PR to 202411: #16861 |
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 8, 2025
…ate_limit to eliminate intermittent failures (sonic-net#16682) This PR addresses an issue where the syslog rate_limit configuration command does not take effect properly because certain containers are not fully initialized before the command execution. To resolve this, "safe reload" option has been added to the config reload. This ensures that all containers and critical processes are up and running before the configuration is applied, ensuring successful configuration What is the motivation for this PR? Fix intermittent failure caused by containers not up before rate_limit config command execution How did you do it? Added safe=True option to config reload How did you verify/test it? Run test_syslog_rate_limit testcase on Nokia-7215 platforms Co-authored-by: karavasi <olympia.karavasili_arapogianni@nokia.com>
|
Cherry-pick PR to 202405: #16862 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Feb 10, 2025
…ate_limit to eliminate intermittent failures (#16682) This PR addresses an issue where the syslog rate_limit configuration command does not take effect properly because certain containers are not fully initialized before the command execution. To resolve this, "safe reload" option has been added to the config reload. This ensures that all containers and critical processes are up and running before the configuration is applied, ensuring successful configuration What is the motivation for this PR? Fix intermittent failure caused by containers not up before rate_limit config command execution How did you do it? Added safe=True option to config reload How did you verify/test it? Run test_syslog_rate_limit testcase on Nokia-7215 platforms Co-authored-by: karavasi <olympia.karavasili_arapogianni@nokia.com>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Feb 10, 2025
…ate_limit to eliminate intermittent failures (#16682) This PR addresses an issue where the syslog rate_limit configuration command does not take effect properly because certain containers are not fully initialized before the command execution. To resolve this, "safe reload" option has been added to the config reload. This ensures that all containers and critical processes are up and running before the configuration is applied, ensuring successful configuration What is the motivation for this PR? Fix intermittent failure caused by containers not up before rate_limit config command execution How did you do it? Added safe=True option to config reload How did you verify/test it? Run test_syslog_rate_limit testcase on Nokia-7215 platforms Co-authored-by: karavasi <olympia.karavasili_arapogianni@nokia.com>
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
This PR addresses an issue where the syslog rate_limit configuration command does not take effect properly because certain containers are not fully initialized before the command execution. To resolve this, "safe reload" option has been added to the config reload. This ensures that all containers and critical processes are up and running before the configuration is applied, ensuring successful configuration
Summary:
Fixes # (issue)
Intermittent syslog_rate_limit testcase failure on Nokia-7215 platforms
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix intermittent failure caused by containers not up before rate_limit config command execution
How did you do it?
Added safe=True option to config reload
How did you verify/test it?
Run test_syslog_rate_limit testcase on Nokia-7215 platforms
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation