Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shortcut paths to point to the exe launchers instead of the cmd files #24

Closed
julianxhokaxhiu opened this issue Apr 20, 2021 · 2 comments · Fixed by #50
Closed

Fix shortcut paths to point to the exe launchers instead of the cmd files #24

julianxhokaxhiu opened this issue Apr 20, 2021 · 2 comments · Fixed by #50

Comments

@julianxhokaxhiu
Copy link

Hi,

I was quite confused when trying to configure my MSYS2 environment after i edited the relative ini files. Upon launching manually the msys2.exe files the ini file was inherited, then upon launching start menu shortcuts it wasn't.

To my surprise I noticed the created shortcuts were pointing to the cmd files which are not considering the ini file somehow. Can you please fix the shortcuts to just use the .exe launchers respectively?

This would solve ton of usability issues against MSYS2.

Thank you in advance,
Julian
@lazka lazka transferred this issue from msys2/msys2.github.io Apr 20, 2021
lazka added a commit to lazka/msys2-installer that referenced this issue Aug 15, 2022
@lazka
shortcuts: start launcher and rename
6584334 
Instead of calling msys2_shell.cmd call the respective launchers.
This unifies the way MSYS2 is started for most users and allows them
to set launch variables in the launcher .ini files.

While at it also rename the shortcuts to reference the environment names
instead of describing the environment. Not everyone might care or know
what these mean, so just unify them with the MSYSTEM env var which is
shown when starting bash right after.

Fixes msys2#24
@lazka lazka mentioned this issue Aug 15, 2022
Merged
@lazka lazka closed this as completed in #50 Aug 15, 2022
lazka added a commit that referenced this issue Aug 15, 2022
@lazka
shortcuts: start launcher and rename
2480a1e 
Instead of calling msys2_shell.cmd call the respective launchers.
This unifies the way MSYS2 is started for most users and allows them
to set launch variables in the launcher .ini files.

While at it also rename the shortcuts to reference the environment names
instead of describing the environment. Not everyone might care or know
what these mean, so just unify them with the MSYSTEM env var which is
shown when starting bash right after.

Fixes #24
@lazka
Copy link
Member

lazka commented Aug 15, 2022

sorry for the delay, will be in the next version

@goyalyashpal
Copy link

goyalyashpal commented Jan 25, 2023 •
edited
Loading

This would solve ton of usability issues against MSYS2.

hey @julianxhokaxhiu , yeah, I also faced one where setting up CompSpec broke the start menu shortcuts (the .cmd file).

So, other than those 2, I'd be interested in knowing what are other usability issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shortcuts: start launcher and rename lazka/msys2-installer
3 participants
@lazka @julianxhokaxhiu @goyalyashpal