Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcuts: start launcher and rename #50

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Conversation

lazka
Copy link
Member

@lazka lazka commented Aug 15, 2022

Instead of calling msys2_shell.cmd call the respective launchers.
This unifies the way MSYS2 is started for most users and allows them
to set launch variables in the launcher .ini files.

While at it also rename the shortcuts to reference the environment names
instead of describing the environment. Not everyone might care or know
what these mean, so just unify them with the MSYSTEM env var which is
shown when starting bash right after.

Fixes #24

Instead of calling msys2_shell.cmd call the respective launchers.
This unifies the way MSYS2 is started for most users and allows them
to set launch variables in the launcher .ini files.

While at it also rename the shortcuts to reference the environment names
instead of describing the environment. Not everyone might care or know
what these mean, so just unify them with the MSYSTEM env var which is
shown when starting bash right after.

Fixes msys2#24
@goyalyashpal
Copy link

Instead of calling msys2_shell.cmd

One more benefit of this is that:

  • calling the .cmd file runs it with the shell defined at the system environment variable CompSpec
  • so, in case the user had redefined that variable to something else
    (say to choose a different shell: bash as a system wide default - rather than configuring individual terminals)
  • then these scripts would open with that shell, hence will likely fail
  • like they did in above mentioned issue MSYS2_shell.cmd file not launching MSYS2-packages#3102

So, setting a default shell in effect was prohibiting effective use of it. Wow!

But using .exe elevates these launcher from this unwanted dependency on CompSpec env variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix shortcut paths to point to the exe launchers instead of the cmd files
2 participants