Modulo Core agora precisa ser transpilado antes de usar #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardomoroni
commented
Dec 8, 2018
| @@ -4,6 +4,7 @@ | |||
| "private": false, | |||
| "main": "dist/index.js", | |||
| "scripts": { | |||
| "postinstall": "npm run build", | |||
There was a problem hiding this comment.
Após npm install o npm automaticamente rodará a build
| export * from './useCases'; | ||
| export * from './frameworks'; | ||
| export * from './entities'; | ||
| import { |
There was a problem hiding this comment.
Esta verboso, mas esta é a melhor maneira de conseguir ter auxilio da IDE e conseguir importar as coisas direto de 'core'
| ReduxAdapter, | ||
| AuthenticationInteractor, | ||
| CounterInteractor, | ||
| } from 'core'; |
There was a problem hiding this comment.
perceba que o from 'core' pode ser usado agora. Graçcas aquele core/src/index.js verbosao
LeoMosiah
approved these changes
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De acordo com a discussão em facebook/create-react-app#4517, não é possivel que o CRA transpile modulos que estejam dentro da pasta
node_modules.Por enquanto vamos manter esta etapa manual.
Voce precisa ir dentro do modulo core e rodar o comando:
npm run build, este comando vai transformar o código dentro desrcparadist. O modulo web e mobile irão consumir os arquivos de dentro da pastadiste não da pastasrc.Em breve configurarei o nosso próprio CRA https://github.com/mtg-community/create-react-app, de acordo com https://medium.com/@denis.zhbankov/maintaining-a-fork-of-create-react-app-as-an-alternative-to-ejecting-c555e8eb2b63
NOTA: este PR deleta a pasta
web/src/core