Deploy App no Firebase Hosting #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoMosiah
approved these changes
Dec 9, 2018
eduardomoroni
commented
Dec 9, 2018
| @@ -8,6 +8,10 @@ ci-check: | |||
| build: | |||
| npm run build | |||
|
|
|||
| deploy: | |||
| npm run build | |||
| @npx firebase deploy --token ${FIREBASE_DEPLOY_TOKEN} | |||
There was a problem hiding this comment.
No makefile quando voce começa um commando com @ este comando não vai ser mostrado na tela. Eu fiz isso porque estamos usando uma variavel de ambiente para fazer o deploy. Se alguem pegar esse token, a pessoa consegue ter acesso ao nosso projeto.
${VARIAVEL_DE_AMBIENTE} é a maneira de se usar uma variavel de ambiente com makefile
There was a problem hiding this comment.
O CI executou o comando make web_deploy mas não da para ver nos logs o token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mergea #17 antes.
https://trading-card-manager-mtgx.firebaseapp.com/