Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix Firefox browser version in karma profile config and resolve user-event test TODOs #353

Conversation

ZeeshanTamboli
Copy link
Member

Typo spotted from #179 while working on mui/material-ui#42008.

Not certain if we've ever executed performance monitoring tests.

Additionally, I considered refactoring these TODOs:

now that we support the new Safari version, but I believe these components will undergo a refactor with a new API, so I left them as is.

@michaldudak
Copy link
Member

Thanks!
As for the tests, we'd like to reuse as much as we can, so refactoring them will be useful anyway.

@ZeeshanTamboli
Copy link
Member Author

Thanks! As for the tests, we'd like to reuse as much as we can, so refactoring them will be useful anyway.

Okay, I resolved the TODOs. Here's the browserstack-force run - https://app.circleci.com/pipelines/github/mui/base-ui/1317/workflows/61c67cfd-9b6f-408c-9fe0-60c6f99fad69/jobs/7582.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [test] Fix Firefox browser version in karma profile config [test] Fix Firefox browser version in karma profile config and resolve user-event test TODOs Apr 25, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 5e53fd2 into mui:master May 1, 2024
16 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the fix-firefox-version-in-kamra-profile-config branch May 1, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants