-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Fix Firefox browser version in karma profile config and resolve user-event test TODOs #353
Merged
ZeeshanTamboli
merged 12 commits into
mui:master
from
ZeeshanTamboli:fix-firefox-version-in-kamra-profile-config
May 1, 2024
Merged
[test] Fix Firefox browser version in karma profile config and resolve user-event test TODOs #353
ZeeshanTamboli
merged 12 commits into
mui:master
from
ZeeshanTamboli:fix-firefox-version-in-kamra-profile-config
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! |
Okay, I resolved the TODOs. Here's the |
michaldudak
reviewed
Apr 24, 2024
…/github.com/ZeeshanTamboli/base-ui into fix-firefox-version-in-kamra-profile-config
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 25, 2024
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 25, 2024
ZeeshanTamboli
changed the title
[test] Fix Firefox browser version in karma profile config
[test] Fix Firefox browser version in karma profile config and resolve user-event test TODOs
Apr 25, 2024
michaldudak
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo spotted from #179 while working on mui/material-ui#42008.
Not certain if we've ever executed performance monitoring tests.
Additionally, I considered refactoring these TODOs:
now that we support the new Safari version, but I believe these components will undergo a refactor with a new API, so I left them as is.