Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix Firefox browser version in karma profile config and resolve user-event test TODOs #353

Merged
merged 12 commits into from
May 1, 2024
Merged

[test] Fix Firefox browser version in karma profile config and resolve user-event test TODOs #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
baf6b9a
Fix Firefox version in karma profile config
ZeeshanTamboli Apr 23, 2024
6e0c51a
userEvent setup in tests
ZeeshanTamboli Apr 24, 2024
449afbc
Merge branch 'master' into fix-firefox-version-in-kamra-profile-config
ZeeshanTamboli Apr 24, 2024
f1819da
call userEvent.setup() before render
ZeeshanTamboli Apr 25, 2024
d15e54c
Merge branch 'master' into fix-firefox-version-in-kamra-profile-config
ZeeshanTamboli Apr 25, 2024
91cf349
remove pnpm lock file
ZeeshanTamboli Apr 25, 2024
dfb03fb
Merge branch 'fix-firefox-version-in-kamra-profile-config' of https:/…
ZeeshanTamboli Apr 25, 2024
013fae0
remove changes in pnpm-lock.yaml file
ZeeshanTamboli Apr 25, 2024
9be8cce
revert
ZeeshanTamboli Apr 25, 2024
dd0ef00
revert pnpm-lock.yaml
ZeeshanTamboli Apr 25, 2024
42850e3
Merge branch 'master' into fix-firefox-version-in-kamra-profile-config
ZeeshanTamboli Apr 25, 2024
8a9f8d0
Merge branch 'master' into fix-firefox-version-in-kamra-profile-config
ZeeshanTamboli May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/mui-base/src/MenuButton/MenuButton.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ import {
} from '@base_ui/react/useDropdown';
import { describeConformanceUnstyled } from '../../test/describeConformanceUnstyled';

// TODO v6: initialize @testing-library/user-event using userEvent.setup() instead of directly calling methods e.g. userEvent.click() for all related tests in this file
// currently the setup() method uses the ClipboardEvent constructor which is incompatible with our lowest supported version of iOS Safari (12.2) https://github.com/mui/material-ui/blob/master/.browserslistrc#L44
// userEvent.setup() requires Safari 14 or up to work

const testContext: DropdownContextValue = {
dispatch: () => {},
popupId: 'menu-popup',
Expand Down Expand Up @@ -146,6 +142,8 @@ describe('<MenuButton />', () => {
dispatch: dispatchSpy,
};

const user = userEvent.setup();

const { getByRole } = render(
<DropdownContext.Provider value={context}>{buttonComponent}</DropdownContext.Provider>,
);
Expand All @@ -155,7 +153,7 @@ describe('<MenuButton />', () => {
button.focus();
});

await userEvent.keyboard(`{${key}}`);
await user.keyboard(`{${key}}`);

expect(dispatchSpy.calledOnce).to.equal(true);
expect(dispatchSpy.args[0][0]).to.contain({ type: DropdownActionTypes.open });
Expand All @@ -171,6 +169,8 @@ describe('<MenuButton />', () => {
dispatch: dispatchSpy,
};

const user = userEvent.setup();

const { getByRole } = render(
<DropdownContext.Provider value={context}>{buttonComponent}</DropdownContext.Provider>,
);
Expand All @@ -180,7 +180,7 @@ describe('<MenuButton />', () => {
button.focus();
});

await userEvent.keyboard(`{${key}}`);
await user.keyboard(`{${key}}`);

expect(dispatchSpy.calledOnce).to.equal(true);
expect(dispatchSpy.args[0][0]).to.contain({ type: DropdownActionTypes.toggle });
Expand Down
Loading