Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stepper] Breadcrumb like #13176

Closed
bluepeter opened this issue Oct 10, 2018 · 7 comments
Closed

[Stepper] Breadcrumb like #13176

bluepeter opened this issue Oct 10, 2018 · 7 comments
Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@bluepeter
Copy link

bluepeter commented Oct 10, 2018

Upgrading from 3.1.1. to 3.2.0, we now get warnings when we use a Stepper with a custom connector like this:

import { ChevronRight } from "mdi-material-ui";

// ...

<Stepper className="breadcrumb" connector={<ChevronRight />}>
  {arr.map(item => item)}
</Stepper>

The warnings we receive are:

screen shot 2018-10-09 at 5 12 04 pm

We've tried multiple solutions here, none successful.

@eps1lon
Copy link
Member

eps1lon commented Oct 11, 2018

How is the interface for ChevronRight defined? We are passing some state related props to the connector and if you pass them through to the dom you will get those warnings.

We should maybe add an interface definition to the docs.

@eps1lon eps1lon added the component: stepper This is the name of the generic UI component, not the React module! label Oct 11, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 11, 2018

@bluepeter This is smart, I never thought of using the stepper for building a breadcrumb component #8818. You have to do something like:

import { ChevronRight } from "mdi-material-ui";

const Connector = () => <ChevronRight />;

<Stepper className="breadcrumb" connector={<Connector />}>
  {arr.map(item => item)}
</Stepper>

@mbrookes
Copy link
Member

Could we add it to the docs as a customization example, which would close #8818?

@bluepeter
Copy link
Author

Thanks @oliviertassinari your solution fixes this issue for me.

Per @mbrookes note, I think the Stepper works nicely as Breadcrumbs.

screenshot-localhost-3000-2018 10 15-15-36-16

Closing.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 15, 2018
@oliviertassinari
Copy link
Member

I agree with @mbrookes, I think that we could add a demo about it.

@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Oct 16, 2018
@oliviertassinari oliviertassinari changed the title [Stepper] custom connector is throwing warnings [Stepper] Breadcrumb like Oct 16, 2018
@bdeloeste
Copy link
Contributor

I'd like to have a go at this issue 😄

@oliviertassinari
Copy link
Member

We have introduced a new Breadcrumb component #14084.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

5 participants