Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Steppers] Add example for breadcrumbs using Steppers #13333

Closed
wants to merge 2 commits into from

Conversation

bdeloeste
Copy link
Contributor

@bdeloeste bdeloeste commented Oct 21, 2018

As per #13176, included an example in docs for using <Steppers /> to implement breadcrumbs.

@@ -68,6 +68,10 @@ This component uses a customized `StepConnector` element that changes border col

{{"demo": "pages/demos/steppers/CustomizedStepper.js"}}

## Breadcrumbs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a description here along the lines of: "The stepper components can be repurposed to create navigation breadcrumbs."

Trivia - breadcrumbs were one of the first web-server plugin components I ever created (back in 1998), but I didn't know they were called that then, so it was called "clickable path".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

I did some digging to try to find the origin and also found another alias: "Cookie crumbs" (https://en.wikipedia.org/wiki/Breadcrumb_(navigation)).

Copy link
Member

@mbrookes mbrookes Oct 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also did some digging, and would you believe, it's still out there!

http://source.riverweb.com/modules/modinfo.html?id=37

This was for Roxen, a web server that was so far ahead of its time. You could add plugins ("modules"), and their configuration page would show up in the web server's web GUI. It supported "RXML" which allowed you to embed tags in your html pages, that would then be converted by the respective module to HTML, images, etc. when the page was requested.

Sadly Apache won out at the time, and Roxen went on to become a niche CMS.

@mui mui deleted a comment from oliviertassinari Oct 22, 2018
@mui mui deleted a comment from oliviertassinari Oct 22, 2018
@mui mui deleted a comment from oliviertassinari Oct 22, 2018
@mui mui deleted a comment from oliviertassinari Oct 22, 2018
@bdeloeste
Copy link
Contributor Author

@oliviertassinari I saw your screenshot, are there still issues indexing Breadcrumbs for Algolia?

@mbrookes
Copy link
Member

@bdeloeste GitHub has been having issues, leading to repeated comments / lost comments, and so on.

I believe the image that @oliviertassinari posted was showing that you are resolving one of the top items that users search for that currently comes up blank. Consider it a big 👍 for this PR!

@oliviertassinari
Copy link
Member

I'm wondering about mixing the Stepper use case with the Breadcrumb 🤔. Let me benchmark the alternatives, just to be sure.

@eps1lon
Copy link
Member

eps1lon commented Oct 23, 2018

@oliviertassinari I had the same concerns. As per #8818 (comment) I would rather create the described utility component and document breadcrumbs as a possible use case.

You could argue that breadcrumbs are somewhat steps down a hierarchy but a Stepper is IMO for things that are on the same level whereas breadcrumbs are on different levels. It's really only about semantics but Stepper adds a lot of overhead for a simple breadcrumbs use-case.

@bdeloeste
Copy link
Contributor Author

Hm, @eps1lon I agree. Stepper also has the idea of "seeing into the future" and knowing there's going to be a "finish".

@mbrookes
Copy link
Member

@bdeloeste Thanks for taking the time to create this PR 🙏, but following the subsequent discussion, it seems this isn't the right way forward. Let's close for now.

@mbrookes mbrookes closed this Nov 17, 2018
@zannager zannager added the component: stepper This is the name of the generic UI component, not the React module! label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants