Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Breadcrumbs #8818

Closed
MmtBkn opened this issue Oct 23, 2017 · 13 comments · Fixed by #14084
Closed

[Feature request] Breadcrumbs #8818

MmtBkn opened this issue Oct 23, 2017 · 13 comments · Fixed by #14084
Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@MmtBkn
Copy link

MmtBkn commented Oct 23, 2017

Hello,

Thanks for this nice project.

Breadcrumb component would be nice for extra navigation.

http://demo.geekslabs.com/materialize-v1.0/ui-breadcrumbs.html#!

Thank you.

@oliviertassinari

This comment has been minimized.

@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Oct 23, 2017
@oliviertassinari oliviertassinari added new feature New feature or request and removed out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) labels Oct 11, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 11, 2018

I would like to revisit this issue. @mui-org/core-contributors What do you think of supporting such component? Maybe we can do something very simple. Here is a sample by @simoami:
https://codesandbox.io/s/qkvzlx47x9

capture d ecran 2018-10-11 a 10 08 39

Here is vuetfiy version: https://vuetifyjs.com/en/components/breadcrumbs#introduction

@eps1lon
Copy link
Member

eps1lon commented Oct 11, 2018

I would rather focus on components that are in the spec and not (fully) implemented.

Concerning Breadcrumbs I think we can create some utility component that joins it's children with a given separator and also use that for Stepper i.e. Array.prototype.join for components.

@mbrookes
Copy link
Member

mbrookes commented Nov 17, 2018

I've taken a first pass at bringing @simoami's Breadcrumbs component into the lab, and moving towards Material-UI code conventions:

4e06e6b2-312a-45d7-ab02-85814181ca36

No tests or types yet, but I can look into extracting the utility component that @eps1lon suggested, to be used by both Breadcrumbs and Stepper.

@oliviertassinari
Copy link
Member

@mbrookes It looks great 😍 !

@simoami
Copy link
Contributor

simoami commented Nov 18, 2018

@mbrookes Looks great! Let me know if there's anything I can do to help.

@drew-dulgar
Copy link

Hi - is there any time frame for when this will be included in the lab?

@mbrookes
Copy link
Member

mbrookes commented Dec 6, 2018

@DrewBe121212 Apologies - real life got in the way the last few weeks. I'm away next week, but might get some time here or there to look at it again, otherwise it's likely going to be during Christmas.

@drew-dulgar
Copy link

No worries! Totally understandable! You don't happen to have it pushed into a branch anywhere do you? I have a use case for it and wouldn't mind putting it through its paces. If not, no worries as well. I'll have to implement my own version till then.

@MukarramAli1729
Copy link

Not yet there. Any idea? Or should we go with other external package?

@mbrookes
Copy link
Member

mbrookes commented Jan 3, 2019

@DrewBe121212 So sorry, I missed your last comment among the deluge (I don't know how @oliviertassinari manages to keep up!) I've just pushed the branch: https://github.com/mbrookes/material-ui/tree/lab-breadcrumbs

This might give you the diff (not sure if it works for other users: https://github.com/mbrookes/material-ui/pull/new/lab-breadcrumbs)

@mukarramali-tw No, sorry, I took some time out over Christmas to focus on family, as my day job (not MUI) was getting overwhelming; and now I'm prepping for interviews...

If someone else wants to pick this up to continue to clean it up, and to add types & tests, feel free to jump in; otherwise, I haven't forgotten it, I just need to get some other stuff sorted first to try to hopefully free up some time to commit to Material-UI.

@mbrookes
Copy link
Member

mbrookes commented Feb 1, 2019

@simoami Thanks for kick-starting the effort! 👍

@simoami
Copy link
Contributor

simoami commented Feb 8, 2019

Woohoo! Glad it made it to an official release! Thanks @mbrookes and @oliviertassinari for taking it to the next level.

@oliviertassinari oliviertassinari added the component: breadcrumbs This is the name of the generic UI component, not the React module! label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants