Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tab] text color is hardcoded & overall theming issue #1730

Closed
TrySpace opened this issue Sep 26, 2015 · 3 comments
Closed

[Tab] text color is hardcoded & overall theming issue #1730

TrySpace opened this issue Sep 26, 2015 · 3 comments
Labels
component: tabs This is the name of the generic UI component, not the React module!

Comments

@TrySpace
Copy link
Contributor

Why is it hardcoded like:

 color: selected ? 'rgba(255,255,255,1)' : 'rgba(255,255,255,0.6)',

Is there a way to override this?
I've tried every possible Theme override with ThemeManager.setComponentThemes
Things like primaryTextColor don't work, where I'd expect them to
@TrySpace
Copy link
Contributor Author

Also on: http://material-ui.com/#/customization/themes the flatbutton textColor is white when you switch to the dark theme, while the background is too.

image

And the link to the updated theming: https://github.com/callemall/material-ui/releases/tag/v0.12 there is broken

@TrySpace TrySpace changed the title [Tab] text color is hardcoded [Tab] text color is hardcoded & overall theming issue Sep 26, 2015
@mgibeau
Copy link
Contributor

mgibeau commented Sep 27, 2015

Regarding the Tab text color, there's a pull request already which solves that issue, #1523

@matthewoates matthewoates mentioned this issue Sep 28, 2015
Closed
@shaurya947
Copy link
Contributor

@TrySpace see #1746. This has been merged and a new minor release is out with the fix!

This was referenced Jul 28, 2020
Open
Open
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@dmtrKovalenko @oliviertassinari
Improve onError validation (mui#1730)
bffad8f 
* Introduce reason-based validation

* Remove dead validation code

* Implement new validation for TimePicker and DateTimePicker

* Remove redux form docs example

* Add Formik with validation schema example

* More tests

* TimePicker validation tests

* Move parsing min/max date up to the root component

* Use touched state in the formik example

* Remove console.logs

* Fix lint and build errors

* Remove visual regression flakiness with time validation

* Remove emptyInputText

* Fix validation tests

* Commit .size-snapshot

* Implement validation for DateRangePicker.tsx

* Add DateRange validation tests

* Fix linter

* Fix broken design of date rangepicker input parsing

* Remove <Code> from formik examples

* Update yarn.lock

* Update docs/pages/guides/FormikOurValidation.example.tsx

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Update docs/pages/guides/FormikOurValidation.example.tsx

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Update docs/pages/guides/FormikOurValidation.example.tsx

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Update new forms example to be more consolidated with @materail-ui/core

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: tabs This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mgibeau @oliviertassinari @shaurya947 @TrySpace @zannager