Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hard-coded values from theme-manager #1746

Merged
merged 2 commits into from
Sep 28, 2015

Conversation

shaurya947
Copy link
Contributor

Made component-level theme values consistent with the raw theme
Renamed canvasColor raw theme key to alternateTextColor
Updated docs to use new theming values

Made component-level theme values consistent with the raw theme
Renamed canvasColor raw theme key to alternateTextColor
Updated docs to use new theming values
shaurya947 added a commit that referenced this pull request Sep 28, 2015
Removed hard-coded values from theme-manager
@shaurya947 shaurya947 merged commit 4c2d6e8 into mui:master Sep 28, 2015
@shaurya947 shaurya947 deleted the consistent-theming-values branch September 28, 2015 15:59
@clarkie
Copy link

clarkie commented Sep 29, 2015

This is a breaking change and as such should not go into a patch release.

@oliviertassinari
Copy link
Member

Are you saying this regarding canvasColor. Yes, I agree using v0.13.0 instead of v0.12.1 may have been better.

@clarkie
Copy link

clarkie commented Sep 29, 2015

Yes, I have 0.12.x in my package.json so I wouldn't expect any breaking changes. However, according to semver you can change whatever you like when the version is < 1.0

@shaurya947
Copy link
Contributor Author

Sorry about that @clarkie. I truly failed to think about that in the midst of getting rid of hard-coded color values.

Nevertheless, there have been a couple issues recently complaining about the lack of keys in palette and it seems like canvasColor may be coming back. So perhaps the breaking change wouldn't be so breaking after all :-)

@shaurya947
Copy link
Contributor Author

#1762

@KapJI
Copy link
Contributor

KapJI commented Oct 9, 2015

This PR changed appearance for some components such as Slider and LinearProgress. What is the reason for doing that?

@shaurya947
Copy link
Contributor Author

@KapJI the purpose of this PR was to remove hard-coded color values from theme-manager. All color values in the theme-manager should ideally come from the raw-theme, and this was an effort in that direction.

If you don't like the colors, feel free to modify them either in dark-raw-theme, or override component-level styles in your muiTheme object. See http://material-ui.com/#/customization/themes for more details on how to do that.

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@zannager zannager added the customization: theme Centered around the theming features label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants