-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed hard-coded values from theme-manager #1746
Conversation
Made component-level theme values consistent with the raw theme Renamed canvasColor raw theme key to alternateTextColor Updated docs to use new theming values
Removed hard-coded values from theme-manager
This is a breaking change and as such should not go into a patch release. |
Are you saying this regarding |
Yes, I have |
Sorry about that @clarkie. I truly failed to think about that in the midst of getting rid of hard-coded color values. Nevertheless, there have been a couple issues recently complaining about the lack of keys in palette and it seems like |
This PR changed appearance for some components such as Slider and LinearProgress. What is the reason for doing that? |
@KapJI the purpose of this PR was to remove hard-coded color values from If you don't like the colors, feel free to modify them either in |
Made component-level theme values consistent with the raw theme
Renamed canvasColor raw theme key to alternateTextColor
Updated docs to use new theming values