Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canvasColor to theme palette #1762

Merged
merged 1 commit into from
Sep 29, 2015
Merged

Add canvasColor to theme palette #1762

merged 1 commit into from
Sep 29, 2015
+57 −54

Conversation

quanglam2807
Copy link
Contributor

@shaurya947
Copy link
Contributor

@quanglam2807 you probably just need to update the last unit test.

Thanks for this. Could you make sure that you have updated all source files so that any kind of background property now uses the canvasColor instead of alternateTextColor?

@quanglam2807
Copy link
Contributor Author

@shaurya947 Actually, I changed the alternateTextColor to Colors.white so it failed the test and I have set it back to the original value so it's working now.
Also, I am pretty sure that I have changed all the background values of src and docs to canvasColor. No need to say thanks! Your work is amazing and I just want to help a little bit. 👍

shaurya947 added a commit that referenced this pull request Sep 29, 2015
@shaurya947
Merge pull request #1762 from quanglam2807/canvas-color
4066e74 
Add canvasColor to theme palette
@shaurya947 shaurya947 merged commit 4066e74 into mui:master Sep 29, 2015
@shaurya947 shaurya947 mentioned this pull request Sep 29, 2015
Merged
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@dependabot-preview
Bump react-transition-group from 4.3.0 to 4.4.1 (mui#1762)
1206f62 
Bumps [react-transition-group](https://github.com/reactjs/react-transition-group) from 4.3.0 to 4.4.1.
- [Release notes](https://github.com/reactjs/react-transition-group/releases)
- [Changelog](https://github.com/reactjs/react-transition-group/blob/master/CHANGELOG.md)
- [Commits](reactjs/react-transition-group@v4.3.0...v4.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@zannager zannager added the customization: theme Centered around the theming features label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
customization: theme Centered around the theming features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quanglam2807 @shaurya947 @zannager