Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Repositions After Pinch Zoom Safari Mobile #23919

Open
1 of 2 tasks
kmsarsam opened this issue Dec 9, 2020 · 4 comments
Open
1 of 2 tasks

[Popover] Repositions After Pinch Zoom Safari Mobile #23919

kmsarsam opened this issue Dec 9, 2020 · 4 comments
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! component: Popover The React component. component: select This is the name of the generic UI component, not the React module!

Comments

@kmsarsam
Copy link

kmsarsam commented Dec 9, 2020

When selecting an item from a MenuItem, if you try to zoom in it will go out of sight and when you zoom back in, the list will be repositioned away from its original position

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

We have MenuItems for selecting from a dropdown inside of TextFields. On safari on mobile devices, if you zoom in on the MenuItems, you will no longer be able to see them until you zoom out. Once zoomed out, they are no longer in place with where they were.

Expected Behavior 🤔

When selecting an item, you should be able to zoom in on a mobile device to read the text and be able to select an item then zoom out and the MenuItems should be in the same place.

Steps to Reproduce 🕹

(https://material-ui.com/components/menus/)
This behavior happens on the material-ui site for menus.

Steps:

  1. Open the material-ui website on an iPhone or xCode iPhone simulator
  2. Open one of the menus
  3. Zoom all the way in, then move around while zoomed in
  4. Zoom out and the menu will be in a different location out of view

Context 🔦

We have users who would like to navigate through forms zoomed in or would like to zoom in to read the text on the MenuItems without losing their place.

Your Environment 🌎

   System:
    OS: Windows 10 10.0.18363
  Binaries:
    Node: 12.18.4 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - ~\ec\src\Aspen.Canopy.eCommerce\Client\node_modules\.bin\yarn.CMD
    npm: 6.14.6 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 86.0.4240.198
    Edge: Spartan (44.18362.449.0)
  npmPackages:
    @material-ui/core: ^4.5.0 => 4.11.2
    @material-ui/icons: ^4.0.1 => 4.11.2
    @material-ui/lab: ^4.0.0-alpha.28 => 4.0.0-alpha.57
    @material-ui/pickers: ^3.2.4 => 3.2.10
    @material-ui/styles:  4.11.2
    @material-ui/system:  4.11.2
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.11.2
    @types/react: 16.8.2 => 16.8.2
    react: ^16.8.1 => 16.14.0
    react-dom: ^16.8.1 => 16.14.0
    typescript: ^3.5.1 => 3.9.7
@kmsarsam kmsarsam added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 9, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 9, 2020

@kmsarsam Which version of iOS, Safari are you using? Do you have a visual illustration?

@kmsarsam
Copy link
Author

kmsarsam commented Dec 10, 2020 via email

@oliviertassinari oliviertassinari added component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 10, 2020
@oliviertassinari
Copy link
Member

I could reproduce, it seems a bit related to #5750

Dec-10-2020 18-22-11

@oliviertassinari oliviertassinari added the component: Popover The React component. label Dec 10, 2020
@oliviertassinari oliviertassinari changed the title [MenuItem] Repositions After Pinch Zoom Safari Mobile [Popover] Repositions After Pinch Zoom Safari Mobile Dec 10, 2020
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 10, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 10, 2020

It's an issue with the Popover position logic. The Popper component isn't impacted. This issue was already reported in #9802. I think that we need to move forward with the plan of #17636. To have Popover combine Modal + Popper instead of having its own position logic (dropping it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! component: Popover The React component. component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

2 participants