Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popover] Add pointer-events CSS property to enable interactions with the rest of the page #25257

Closed
wants to merge 2 commits into from

Conversation

yehee
Copy link

@yehee yehee commented Mar 7, 2021

Hi! I'm excited to be contributing to this project for the first time. Please let me know if there is anything else that needs to be addressed.

This issue has been addressed several times, and the use case for such change would be to use Popover on hover.

The change introduced is to add pointer-events CSS property to enable interactions with the rest of the page.

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 7, 2021

Details of bundle changes

Generated by 🚫 dangerJS against a6f7e84

@oliviertassinari
Copy link
Member

@yehee The interactions are disabled on purpose by using a Modal. Why should they be enabled while keeping the focus locked?

@oliviertassinari
Copy link
Member

This seems to be a duplicate of #23919 (comment) were we talk about, a flag to disable the modal

@yehee
Copy link
Author

yehee commented Mar 8, 2021

@oliviertassinari Thanks for such a quick lookover! If this is in fact what is expected to behave, perhaps a flag to disable the modal mentioned above sounds like a feature I could work on instead. Would it be something that is available for me to pick up on?

@oliviertassinari
Copy link
Member

@yehee A revamp of the Popover component would be awesome. It's a long-overdue.

@yehee
Copy link
Author

yehee commented Mar 8, 2021

Closed as the behavior is expected.

@yehee yehee closed this Mar 8, 2021
@yehee yehee deleted the popover-onmouseleave branch March 8, 2021 00:18
@yehee yehee mentioned this pull request Mar 9, 2021
1 task
@zannager zannager added the component: Popover The React component. label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popover The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants