-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Failing BrowserStack tests #27991
Comments
I understand the frustration here. Removing firefox or safari is probably the worst solution since those are the browsers who are most likely to deviate from headless chrome. Running them periodically only on the upstream branches makes the most sense in my opinion (failing would result in a blocked release). Though personally I'm all for removing them completely. What they specifically test should really only be either visual regression or e2e tests. Both of these jobs weren't as performant or viable when test_browsers was introduce so this is a good opportunity to re-evaluate what the point of |
I agree that letting the |
@michaldudak I have update the options listed to introduce more diversity. It's also to be noted that #16263 is related to this pain. I personally resonate with options 4. or 5. For instance, we could start with 5, if we see that we introduce regressions too often, then we could invest in 4 to move these tests back on the PRs (maybe it will never get to this). It seems that it's what #28041 goes after (I didn't see it before starting to comment). @flaviendelangle does it work for you? Do you want to cherry-pick this approach in X? |
Fine for me 👍 |
This is a follow-up to #27179 (comment)
The browser test timeouts occur increasingly more often because of the limited processing power of BrowserStack.
Some of the solutions available:
The text was updated successfully, but these errors were encountered: