-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Increase BS timeout to 6min #27179
[test] Increase BS timeout to 6min #27179
Conversation
@eps1lon In https://github.com/mui-org/material-ui-x we proposed to remove Firefox and Edge from the BrowserStack builds during the retrospective. This should allow us to only use 30% of the building capacity for X, compared to what we were previously using cc @m4theushw. However, In CircleCI 2/3 of the credits are used on the core, and 1/3 on the x repo. I assume the ratio is close for the usage of BrowerStack. So even if we reduce the usage of BrowserStack in the x repo, it won't really matter if the core is starving it. Maybe we should do the same here? As for the long-term, maybe we could solve this with:
|
I'm merging as it's a simple change, but the discussion 👆 is I think worth continuing. |
The browser tests would be useless at this point. The rest of the suggestions do not say anything. They are just suggestions of the "what" (least interesting) but don't tell anything what problem they're solving and how. First you have to tell me what the problem is to begin with. I don't see any problem that we need to spend time on. |
@eps1lon There would still be an older version of Chrome and Safari.
From what I understood during the retrospective, the issue is this: The flaky rate on the karma test is close to 50% (test_browser). @m4theushw Would you like to expand on the problem we have? We have tried mui/mui-x#2040. |
It seems that we have added more tests, the run is now slower and more often hit the limit:
https://automate.browserstack.com/dashboard/v2/builds/950ced05fbc968c6ce8e068a01034283c3f98714