Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Increase BS timeout to 6min #27179

Merged

Conversation

oliviertassinari
Copy link
Member

It seems that we have added more tests, the run is now slower and more often hit the limit:

Capture d’écran 2021-07-08 à 11 42 45

https://automate.browserstack.com/dashboard/v2/builds/950ced05fbc968c6ce8e068a01034283c3f98714

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 8, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 1fa19ef

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 10, 2021

@eps1lon In https://github.com/mui-org/material-ui-x we proposed to remove Firefox and Edge from the BrowserStack builds during the retrospective. This should allow us to only use 30% of the building capacity for X, compared to what we were previously using cc @m4theushw.

However, In CircleCI 2/3 of the credits are used on the core, and 1/3 on the x repo. I assume the ratio is close for the usage of BrowerStack. So even if we reduce the usage of BrowserStack in the x repo, it won't really matter if the core is starving it. Maybe we should do the same here?

As for the long-term, maybe we could solve this with:

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 10, 2021

I'm merging as it's a simple change, but the discussion 👆 is I think worth continuing.

@oliviertassinari oliviertassinari merged commit 7caeb81 into mui:next Jul 10, 2021
@oliviertassinari oliviertassinari deleted the increase-timeout-for-firefox branch July 10, 2021 18:03
@eps1lon
Copy link
Member

eps1lon commented Jul 12, 2021

@eps1lon In mui-org/material-ui-x we proposed to remove Firefox and Edge from the BrowserStack builds during the retrospective.

The browser tests would be useless at this point.

The rest of the suggestions do not say anything. They are just suggestions of the "what" (least interesting) but don't tell anything what problem they're solving and how.

First you have to tell me what the problem is to begin with. I don't see any problem that we need to spend time on.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 12, 2021

The browser tests would be useless at this point.

@eps1lon There would still be an older version of Chrome and Safari.

First you have to tell me what the problem is to begin with.

From what I understood during the retrospective, the issue is this:

Capture d’écran 2021-07-12 à 12 44 20

https://app.circleci.com/insights/github/mui-org/material-ui-x/workflows/pipeline/jobs?branch=b1d8acd4-8701-4c76-8a87-7ff2320aa95f&reporting-window=last-30-days

The flaky rate on the karma test is close to 50% (test_browser). @m4theushw Would you like to expand on the problem we have?

We have tried mui/mui-x#2040.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants