[test] Disable BrowserStack for PRs #28041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
test/disable-browserstack-pr
branch
from
5700207 to
ff7ef61
Compare
oliviertassinari
changed the title
|
A follow-up on this PR has been done at #28171. @flaviendelangle I have cherry-picked it on MUI X: mui/mui-x@e6cae75. It's similar to mui/mui-x#2500 but more efficient, as the test_browser step is not BrowserStack only dependent, it also runs in Chrome headless, inside CircleCI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_browserCircleCI jobWe can save a lot of ressources by only running BS on merged commits. BS now acts as a stop gap for broken releases not broken merges.
Closes #27991
Documentation of new workflow
Usual PR run (now with no BrowserStack): https://app.circleci.com/pipelines/github/mui-org/material-ui/51444/workflows/b40d81d2-6f75-431e-b6b6-3b1f480300a2/jobs/290265
PR with
"parameters": { "browserstack-force": true }i.e. with BrowserStack: https://app.circleci.com/pipelines/github/mui-org/material-ui/51447/workflows/7323cfaa-357d-410f-9d4f-2c16cb696b74/jobs/290290