Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectField] Add keyboard support #4181

Closed
luisrudge opened this issue May 6, 2016 · 25 comments
Closed

[SelectField] Add keyboard support #4181

luisrudge opened this issue May 6, 2016 · 25 comments
Labels
accessibility a11y bug 🐛 Something doesn't work

Comments

@luisrudge
Copy link
Contributor

luisrudge commented May 6, 2016

  • Material-UI: v0.15.0-beta.2
  • React: any
  • Browser: any

Steps to reproduce:

@mbrookes mbrookes added the new feature New feature or request label May 6, 2016
@mbrookes
Copy link
Member

mbrookes commented May 6, 2016

@luisrudge please can you make the title more succinct, and put the detail in the description.

Also, did the issue template not come up for you? What browser are you using?

@luisrudge luisrudge changed the title [SelectField] When I open the select field, I should be able to type the first letter of an option and this option should be selected [SelectField] Ability to type first letter of an option and select the option May 6, 2016
@luisrudge
Copy link
Contributor Author

I updated the title and the issue with the relevant info

@nathanmarks nathanmarks changed the title [SelectField] Ability to type first letter of an option and select the option [SelectField] Add keyboard support May 6, 2016
@nathanmarks
Copy link
Member

@luisrudge I can't even tab focus the component (at least in the docs example).

@nathanmarks nathanmarks added bug 🐛 Something doesn't work accessibility a11y and removed new feature New feature or request labels May 6, 2016
@nathanmarks nathanmarks added this to the 0.15.1 Release milestone May 6, 2016
@luisrudge
Copy link
Contributor Author

Thanks @nathanmarks for the help. You're right, there's no keyboard support

@piglovesyou
Copy link
Contributor

This keyboard support is only necessary in SelectField, not in DropDownMenu and Menu. Is this correct?

@luisrudge
Copy link
Contributor Author

I think so

On Fri, May 6, 2016 at 10:01 PM -0700, "piglovesyou" notifications@github.com wrote:

This keyboard support is only necessary in SelectField, not in DropDownMenu and Menu. Is this correct?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#4181 (comment)

@mbrookes
Copy link
Member

mbrookes commented May 7, 2016

@piglovesyou Ideally, from an accessibility standpoint, every component should be keyboard navigable.

@piglovesyou
Copy link
Contributor

@luisrudge @mbrookes Thanks. Because I didn't disagree with @mbrookes I only changed Menu.js. Hope it helps.

@luisrudge
Copy link
Contributor Author

This is great stuff! Thanks @piglovesyou and @mbrookes <3

@kidwm
Copy link

kidwm commented May 20, 2016

Is it possible to also bundle a hidden <select> to support "required" and "form" attributes?

@piglovesyou
Copy link
Contributor

Hi @kidwm , could you be more specific?

@kidwm
Copy link

kidwm commented May 20, 2016

@piglovesyou

<form onInvalid={func}>
<SelectField required>
</SelectField>
</form>

It should trigger onInvalid event if SelectField's value is null.

@piglovesyou
Copy link
Contributor

Oh you're talking about this. But even then I can't figure out why it relates to this issue. I believe this issue only deals with a behavior when you hit a key while <SelectField /> has focus. Can you explain why?

@kidwm
Copy link

kidwm commented May 21, 2016

@piglovesyou They are all about the <select> behavior, I'll file another issue for "required" attribute.

@piglovesyou
Copy link
Contributor

That makes more sense. Thank you for explaining that.

@matthewoates
Copy link
Contributor

old duplicate here: #1544

@matthewoates
Copy link
Contributor

Also, how is SelectField different from DropDownMenu? Looks like the same component implemented twice to me.

@luisrudge
Copy link
Contributor Author

Thanks @mbrookes! 🎉
Any ETA on the next release?

@mbrookes
Copy link
Member

Not planned, but we should probably get a 0.15.1 out soon enough.

@Sigmus
Copy link

Sigmus commented Sep 15, 2016

Using 0.15.4 and not working for me. Working for anyone?

@piglovesyou
Copy link
Contributor

Sad I'll check

@nathanmarks
Copy link
Member

It's being completely reworked on the next branch.

@jbhatab
Copy link

jbhatab commented Dec 18, 2016

@nathanmarks whats the status on this? I tried pulling from master but it didn't quite fix it. I just have a really form heavy app.

@felipenmoura
Copy link

so...one year later, using material-ui-next ... the only way I can allow the user to type a letter and scroll the options to the right position, is by using the native select?
I couldn't find any other issue discussing this, but for me, this is of utter importance, as it directly affects the user interaction and even accessibility.

@piglovesyou
Copy link
Contributor

piglovesyou commented Mar 3, 2018

  • Now the main branch seems to be v1-beta that doesn't include my change
  • master and v1-beta are quite different, so cherry-picking my code toward v1-beta will need some effort

@mbrookes @nathanmarks Could you point out the current status? It seems like this issue is closed although it's not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

9 participants