-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectField] Add keyboard support #4181
Comments
@luisrudge please can you make the title more succinct, and put the detail in the description. Also, did the issue template not come up for you? What browser are you using? |
I updated the title and the issue with the relevant info |
@luisrudge I can't even tab focus the component (at least in the docs example). |
Thanks @nathanmarks for the help. You're right, there's no keyboard support |
This keyboard support is only necessary in SelectField, not in DropDownMenu and Menu. Is this correct? |
I think so On Fri, May 6, 2016 at 10:01 PM -0700, "piglovesyou" notifications@github.com wrote: This keyboard support is only necessary in SelectField, not in DropDownMenu and Menu. Is this correct? You are receiving this because you were mentioned. |
@piglovesyou Ideally, from an accessibility standpoint, every component should be keyboard navigable. |
@luisrudge @mbrookes Thanks. Because I didn't disagree with @mbrookes I only changed Menu.js. Hope it helps. |
This is great stuff! Thanks @piglovesyou and @mbrookes <3 |
Is it possible to also bundle a hidden <select> to support "required" and "form" attributes? |
Hi @kidwm , could you be more specific? |
It should trigger onInvalid event if SelectField's value is null. |
Oh you're talking about this. But even then I can't figure out why it relates to this issue. I believe this issue only deals with a behavior when you hit a key while |
@piglovesyou They are all about the <select> behavior, I'll file another issue for "required" attribute. |
That makes more sense. Thank you for explaining that. |
old duplicate here: #1544 |
Also, how is |
Thanks @mbrookes! 🎉 |
Not planned, but we should probably get a 0.15.1 out soon enough. |
Using 0.15.4 and not working for me. Working for anyone? |
Sad I'll check |
It's being completely reworked on the |
@nathanmarks whats the status on this? I tried pulling from master but it didn't quite fix it. I just have a really form heavy app. |
so...one year later, using material-ui-next ... the only way I can allow the user to type a letter and scroll the options to the right position, is by using the |
@mbrookes @nathanmarks Could you point out the current status? It seems like this issue is closed although it's not solved. |
Steps to reproduce:
<select>
elementSaab
option will be selectedSelectField
componentEvery Night
option should be selectedThe text was updated successfully, but these errors were encountered: