Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stepper] Port component #4799

Closed
4 tasks
nathanmarks opened this issue Jul 22, 2016 · 46 comments
Closed
4 tasks

[Stepper] Port component #4799

nathanmarks opened this issue Jul 22, 2016 · 46 comments
Labels
component: stepper This is the name of the generic UI component, not the React module!

Comments

@nathanmarks
Copy link
Member

nathanmarks commented Jul 22, 2016

  • Component
  • Tests (at least unit tests)
  • Docs
  • Demo
@nathanmarks nathanmarks added this to the 0.16.0 Release milestone Jul 22, 2016
@nathanmarks nathanmarks self-assigned this Jul 22, 2016
@oliviertassinari oliviertassinari added the component: stepper This is the name of the generic UI component, not the React module! label Dec 18, 2016
@alexhayes
Copy link
Contributor

FYI for anyone who's thinking of starting on this I've got a working port which I'm just cleaning up.

@stunaz
Copy link
Contributor

stunaz commented Jul 5, 2017

Hi @alexhayes any update on this?

@alexhayes
Copy link
Contributor

@stunaz I made pretty good progress initially but I've been sick the last week and a bit so things have slowed down (it's mid winter here and colds and the flu are in abundance 🤧). I'm nearly through it all so should be able to spend some more time on it early next week.

@vladimirpekez
Copy link

Hi everyone I just started our material-ui project using v1-alpha. Our UX designer included original stepper in specs so if any help is needed I (or someone from our team) can help with any of stepper migration tasks.

@stunaz
Copy link
Contributor

stunaz commented Jul 13, 2017

ping @alexhayes @oliviertassinari

@alexhayes
Copy link
Contributor

Sorry folks, nothing much has changed from my end, unfortunately I've still got this flu/cold.

I can push up what I've done thus far and happy to work with you on it @vladimirpekez

alexhayes added a commit to alexhayes/material-ui that referenced this issue Jul 13, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Jul 13, 2017
@alexhayes
Copy link
Contributor

alexhayes commented Jul 13, 2017

@vladimirpekez I've pushed my branch which has working ports of the following;

  • Horizontal/Vertical Linear
  • Horizontal Non Linear Stepper

Yet to be done is;

  • Alternative labels
  • Stepper feedback
  • Tests
  • Docs
  • Probably better adherence to the guidelines with respect to sizing, colours etc.
  • Probably more things I've forgot

Note I've only been using Chrome on Mac for testing thus far and only on desktop.

@oliviertassinari oliviertassinari modified the milestone: v1.0.0-prerelease Jul 14, 2017
@oliviertassinari
Copy link
Member

I have been reviewing the existing Stepper component we have on the master branch. I find the API and implementation solid. It's a good starting point. Also, we have some interesting feedback on that version

@oliviertassinari
Copy link
Member

@alexhayes Thanks for sharing what you have done so far! I believe this is the branch you are referring to.

@alexhayes
Copy link
Contributor

alexhayes commented Jul 14, 2017 via email

@vladimirpekez
Copy link

Thanks @alexhayes - we would checkout your branch.

@alexhayes
Copy link
Contributor

@vladimirpekez after being completely bed ridden for the last two weeks with the flu I'm finally back on my feet and I'm wondering how you're getting along with your work on the Stepper port? Do you want to split up a few tasks as I listed above so we don't step on each others toes?

@vladimirpekez
Copy link

vladimirpekez commented Jul 28, 2017 via email

alexhayes added a commit to alexhayes/material-ui that referenced this issue Aug 9, 2017
… padding as per spec, correctly set font weight based upon active and completed status.
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Oct 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
@salamaashoush
Copy link

salamaashoush commented Nov 1, 2017

@oliviertassinari @alexhayes Are you planning to merge this into v1 soon?

alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 1, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 2, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 2, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 8, 2017
alexhayes added a commit to alexhayes/material-ui that referenced this issue Nov 8, 2017
oliviertassinari pushed a commit to alexhayes/material-ui that referenced this issue Nov 11, 2017
oliviertassinari pushed a commit to alexhayes/material-ui that referenced this issue Nov 11, 2017
oliviertassinari pushed a commit that referenced this issue Nov 12, 2017
* [stepper] Stepper port to next - working Horizontal/Vertical Linear and Horizontal Non Linear Stepper. (#4799)

* [stepper] Linting fixes. (#4799)

* One last glimpse
the-noob pushed a commit to the-noob/material-ui that referenced this issue Nov 17, 2017
* [stepper] Stepper port to next - working Horizontal/Vertical Linear and Horizontal Non Linear Stepper. (mui#4799)

* [stepper] Linting fixes. (mui#4799)

* One last glimpse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

6 participants