Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add SkipNav #15409

Merged
merged 9 commits into from
Apr 22, 2019
Merged

[docs] Add SkipNav #15409

merged 9 commits into from
Apr 22, 2019

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Apr 18, 2019 •
edited
Loading

Follows the example here: https://webaim.org/

This is a WIP, as it currently doesn't work when the Nav is open, due to scrollIntoView().

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 18, 2019 •
edited
Loading

Details of bundle changes.

Comparing: e9242f7...4821c6e

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 312,618 312,618 84,447 84,447
@material-ui/core/Paper 0.00% 0.00% 67,279 67,279 19,968 19,968
@material-ui/core/Paper.esm 0.00% 0.00% 60,640 60,640 18,884 18,884
@material-ui/core/Popper 0.00% 0.00% 34,907 34,907 11,812 11,812
@material-ui/core/Textarea 0.00% 0.00% 5,327 5,327 2,291 2,291
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,898 15,898 5,771 5,771
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 974 974
@material-ui/lab 0.00% 0.00% 141,612 141,612 42,722 42,722
@material-ui/styles 0.00% 0.00% 50,833 50,833 15,013 15,013
@material-ui/system 0.00% 0.00% 11,765 11,765 3,928 3,928
Button 0.00% 0.00% 85,621 85,621 25,588 25,588
Modal 0.00% 0.00% 79,901 79,901 24,011 24,011
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing +0.21% 🔺 +0.30% 🔺 50,908 51,014 11,210 11,244
docs.main +0.10% 🔺 +0.08% 🔺 648,518 649,193 201,926 202,084
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 293,911 293,911 82,492 82,492

Generated by 🚫 dangerJS against 4821c6e

@mbrookes
[docs] Add skipnav
4e4ca97 
Follows the example here: https://webaim.org/
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 18, 2019 •
edited
Loading

+1 for the isolation of concern. It would be better to group the skip nav logic. Why is scroll into view an issue? What about using the same API as https://ui.reach.tech/skip-nav? The implementation abstraction cost could be minimal: https://github.com/reach/reach-ui/blob/master/packages/skip-nav/src/index.js.

@mbrookes

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation new feature New feature or request labels Apr 19, 2019
oliviertassinari
oliviertassinari reviewed Apr 19, 2019
View reviewed changes
docs/src/modules/components/AppContent.js Outdated Show resolved Hide resolved
docs/src/modules/components/AppFrame.js Outdated Show resolved Hide resolved
docs/src/modules/components/AppFrame.js Outdated Show resolved Hide resolved
docs/src/modules/components/AppFrame.js Outdated Show resolved Hide resolved
@oliviertassinari

This comment has been minimized.

Sign in to view
@oliviertassinari oliviertassinari added accessibility a11y and removed new feature New feature or request labels Apr 19, 2019
@oliviertassinari oliviertassinari changed the title [docs] Add skipnav [docs] Add SkipNav Apr 19, 2019
@mbrookes mbrookes marked this pull request as ready for review April 21, 2019 11:48
oliviertassinari
oliviertassinari reviewed Apr 21, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect 💎👌.

docs/src/modules/components/AppDrawerNavItem.js Show resolved Hide resolved
docs/src/modules/components/AppFrame.js Show resolved Hide resolved
docs/src/modules/components/AppFrame.js Outdated Show resolved Hide resolved
docs/src/modules/components/AppContent.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari merged commit ccca9a1 into mui:next Apr 22, 2019
@mbrookes mbrookes deleted the docs-skipnav branch March 15, 2020 23:02
@oliviertassinari oliviertassinari mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbrookes @mui-pr-bot @oliviertassinari