-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix scroll shift #24418
[docs] Fix scroll shift #24418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That scroll flipping is so annoying.
Though it seems like there is still some unstable scrolling:
Profiler filmstrip:
Profile: https://drive.google.com/file/d/1AMxC9PBf0may4TtrRHkU_uBSnA_ru8og/view?usp=sharing
@eps1lon This is a different issue and only reproducible when there is a hash in the URL. I can observe the following: Next.js's reset the scroll with the I have reported the bug in vercel/next.js#13653 (comment). Thanks @dmtrKovalenko for reporting it in https://twitter.com/dmtrKovalenko/status/1348936828271910914. if we destructure your video there are 4 different issues bundled at once:
|
It's this exact issue that is still reproducible after scroll. So we did improve it, but not fully fix it. |
I had a look at why the scroll into view was added. It's explained in #15409 (comment). I can't reproduce anymore |
The bug:
Enregistrement.de.l.ecran.2021-01-14.a.18.31.50.mp4
The origin: https://github.com/mui-org/material-ui/pull/15409/files#diff-e33c632b2237fb5233ca8600034cf02952cfaa668c9d6a5d08d5252891059d9dR59 @mbrookes Do you remember the issue this line was meant to fix?
Compare the loading UX between these two: