-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] Adjust table styles to the latest specs #17388
Conversation
Details of bundle changes.Comparing: 1a480fe...82753b3
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm on my phone, I can't have deep dive yet. I think that we should update the max height value of the "fixed header" demo to account the change of the rows' height. |
40dd8e5
to
60e3db6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question about the width of the cell was, why do the table cells take up more horizontal space than they need to? (Not specific to this PR, just in general.)
@mbrookes The table layout mode has always puzzled me 😁. In this case, it's on purpose, the demo tries to showcase vertical and horizontal scrolling support.
Oh, we have min-width set. I don't know how I missed it!! 🤦♂️ |
@mbrookes @oliviertassinari Speaking about outer border... |
@kybarg Interesting, I don't think that the table component should come with an outline by default. However, I think that would be great to support it. I think that we could have two follow-up pull requests:
What do you think? |
On July 25, 2019 Google updated Specs on Table component. Padding and fonts were updated