React 0.14 support #1790
React 0.14 support #1790
Conversation
Temporarily included personal fork until pull-request is accepted upstream.
- Replaced unix command with rimraf for cross-platform support - Updated dependencies to resolve warnings - Updated to temporary fork of react-draggable2 with 0.14 support.
| @@ -68,6 +75,7 @@ | |||
| "phantomjs": "^1.9.17", | |||
| "react-hot-loader": "^1.2.8", | |||
| "react-router": "^1.0.0-rc1", | |||
| "rimraf": "^2.4.3", | |||
There was a problem hiding this comment.
Why is it a peerDependency and not a dependency?
I feel like this is not link to react v0.14 and should be added to master
There was a problem hiding this comment.
It's not, it's a devDependency. You may have to expand your diff.
True, but I needed Windows compatibility to test and continue developing this branch.
There was a problem hiding this comment.
Oh sorry, I'm on my phone.
Contains React 0.14 compatibility fixes.
|
Do we agree on merging this PR? Or is there another approach that we'd rather take? @Cavitt @cgestes @oliviertassinari |
|
I moved the dependencies needed for testing into dev dependencies. Test dependencies generally go in dev dependencies in my experience, let me know if this doesn't work for you guys and I'll come up with another way. |
|
That's fine for me 👍 |
|
👍 |
|
Merging this then. Thanks @Cavitt |
|
I just tried pulling this branch, rebasing with master, and resolving conflicts using the code in this branch. I ran I'm looking into it but thought I'd let you guys know so we can get this working soon. |
0.7.0-alpha1which contains React 0.14 compatibility fixes.