React 0.14 - TaskList

[cgestes]

What need to be done to support react-0.14 on the react-0.14-support branch.

• React.findDOMNode -> ReactDOM.findDOMNode
• require('react/addons') -> require('react-addons-*')
• React-Router 1.0 support
• react-draggable2 still require react 0.13 and react-addons
• code highlight not working on the doc website
• PR React 0.14 support doc #1866 check hot-reload for the doc dev server
• PR [React-v14] Use findDOMNode where needed and fix package #1859 getDOMNode is still used in some places
• PR [React-v14] Use findDOMNode where needed and fix package #1859 Update package.json to last version (0.14-rc1 -> 0.14)

[cgestes]

@oliviertassinari @shaurya947 can you add the items you think are missing if any?

thank you.

[oliviertassinari]

Yes, react-draggable2 require react v0.13 and react-addons, this throw a warning

[NogsMPLS]

Don't think hot loading is working on local docs dev server. Change is made, page refreshes with 'cannot GET' and then the route. Possible a hot-loader or a react-router issue?

[cgestes]

I think it's related to routes. (historyApiFallback need to be activated on
the dev server)

On Fri, Oct 2, 2015 at 5:15 PM, Nathan Smith notifications@github.com
wrote:

Don't think hot loading is working on local docs dev server. Change is
made, page refreshes with 'cannot GET' and then the route. Possible a
hot-loader or a react-router issue?

—
Reply to this email directly or view it on GitHub
#1782 (comment)
.

[shaurya947]

Yep, confirming the issue that @NogsMPLS reported.

[TheUltDev]

@cgestes pr #1790 should solve fix remainings warning and react-draggable2 list items.

[luisrudge]

👍

[bdefore]

👍

[oliviertassinari]

I have some warnings when openning a Dialog :

Warning: Dialog.getDOMNode(...) is deprecated. Please use ReactDOM.findDOMNode(instance) instead.warning @ warning.js:45ReactBrowserComponentMixin.getDOMNode @ ReactBrowserComponentMixin.js:30proxiedMethod @ createPrototypeProxy.js:44_positionDialog @ dialog.jsx:412proxiedMethod @ createPrototypeProxy.js:44componentDidUpdate @ dialog.jsx:214proxiedMethod @ createPrototypeProxy.js:44assign.notifyAll @ CallbackQueue.js:65ON_DOM_READY_QUEUEING.close @ ReactReconcileTransaction.js:81Mixin.closeAll @ Transaction.js:202Mixin.perform @ Transaction.js:149Mixin.perform @ Transaction.js:136assign.perform @ ReactUpdates.js:86flushBatchedUpdates @ ReactUpdates.js:147wrapper @ ReactPerf.js:66Mixin.closeAll @ Transaction.js:202Mixin.perform @ Transaction.js:149ReactDefaultBatchingStrategy.batchedUpdates @ ReactDefaultBatchingStrategy.js:62enqueueUpdate @ ReactUpdates.js:176enqueueUpdate @ ReactUpdateQueue.js:24ReactUpdateQueue.enqueueSetState @ ReactUpdateQueue.js:190ReactComponent.setState @ ReactComponent.js:64show @ dialog.jsx:342proxiedMethod @ createPrototypeProxy.js:44(anonymous function) @ Dialog.jsx:66
warning.js:45 Warning: ReactTransitionGroup.getDOMNode(...) is deprecated. Please use ReactDOM.findDOMNode(instance) instead.warning @ warning.js:45ReactBrowserComponentMixin.getDOMNode @ ReactBrowserComponentMixin.js:30_positionDialog @ dialog.jsx:413proxiedMethod @ createPrototypeProxy.js:44componentDidUpdate @ dialog.jsx:214proxiedMethod @ createPrototypeProxy.js:44assign.notifyAll @ CallbackQueue.js:65ON_DOM_READY_QUEUEING.close @ ReactReconcileTransaction.js:81Mixin.closeAll @ Transaction.js:202Mixin.perform @ Transaction.js:149Mixin.perform @ Transaction.js:136assign.perform @ ReactUpdates.js:86flushBatchedUpdates @ ReactUpdates.js:147wrapper @ ReactPerf.js:66Mixin.closeAll @ Transaction.js:202Mixin.perform @ Transaction.js:149ReactDefaultBatchingStrategy.batchedUpdates @ ReactDefaultBatchingStrategy.js:62enqueueUpdate @ ReactUpdates.js:176enqueueUpdate @ ReactUpdateQueue.js:24ReactUpdateQueue.enqueueSetState @ ReactUpdateQueue.js:190ReactComponent.setState @ ReactComponent.js:64show @ dialog.jsx:342proxiedMethod @ createPrototypeProxy.js:44(anonymous function) @ Dialog.jsx:66
warning.js:45 Warning: ReactDOMComponent: Do not access .getDOMNode() of a DOM node; instead, use the node directly. This DOM node was rendered by `Dialog`.

getDOMNode is still used in some places.

[newtack]

How about leveraging some of the FB tools? https://github.com/facebook/react/blob/master/packages/react-codemod/README.md

[mooncakelmn]

Haven't tried the findDOMNode tool, but the one for pure-render-mixin is adding shouldComponentUpdate for each pure component, which is not so cool.

[mooncakelmn]

Tried with findDOMNode tool, it replaces this.refs.foo.getDOMNode() to React.findDOMNode(this.refs.foo), which is not so cool either...

[shaurya947]

@cgestes @oliviertassinari the issues with the doc site is pretty much what's holding us back from an official release. Once we can get that going, we could release a react-v0.14 compliant version soon.

[cgestes]

merging all remaining PR seems to fix most known issues. :)

Olivier and I think it's time to think about merging to master.

[mooncakelmn]

👍

[cgestes]

merged to master :)

[luisrudge]

wow. Congratz!

[heyheyjp]

🎉

[ka2n]

㊗️ 🎊

[sanemat]

Would you bump the version?

[yuliroth]

+1

[neerfri]

Thanks for this!!!
+1 on the version bump!

[oliviertassinari]

Yeah, I think that we could do a pre-release. Something like 0.13.0-rc1.