[React-v14] Use findDOMNode where needed and fix package #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix some of #1782 |
| @@ -23,7 +23,7 @@ var config = { | |||
| }, | |||
| //Modules will be searched for in these directories | |||
| modulesDirectories: [ | |||
| "web_modules", | |||
There was a problem hiding this comment.
isn't it redundant with the line bellow?
There was a problem hiding this comment.
Webpack fail for me without.
There was a problem hiding this comment.
strange... all node_modules of the project are supposed to be included in a 'whatever the current directory is' manner just bellow..
There was a problem hiding this comment.
Hum, with the default modulesDirectories yes. But I think that since we overide it, it's no longer true.
|
Thanks @oliviertassinari |
shaurya947
added a commit
that referenced
this pull request
Oct 14, 2015
[React-v14] Use findDOMNode where needed and fix package
Closed
| @@ -78,8 +79,8 @@ const CalendarYear = React.createClass({ | |||
| _scrollToSelectedYear() { | |||
| if (this.refs.selectedYearButton === undefined) return; | |||
|
|
|||
| let container = this.getDOMNode(); | |||
| let yearButtonNode = this.refs.selectedYearButton.getDOMNode(); | |||
| let container = this.findDOMNode(); | |||
There was a problem hiding this comment.
should be ReactDOM.findDOMNode(this);
Fixed in #1882
|
@oliviertassinari are you working on fixing these? |
|
@shaurya947 Yes here #1882. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-rc1with the offical release.^instead of>=to prevent future breaking changes with react v0.15.getDOMNode.