Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Don't force a remote when listing prettier changes #18794

Merged
merged 8 commits into from
Dec 27, 2019
Merged

[core] Don't force a remote when listing prettier changes #18794

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3db49a5
[scripts] prettier: don't force a remote when listing changes
Janpot Dec 11, 2019
33267e5
test prettier in ci
Janpot Dec 12, 2019
f809c1c
with upstream/master?
Janpot Dec 12, 2019
3e24ac1
with origin/master?
Janpot Dec 12, 2019
ef67d8a
Maybe conditionally?
Janpot Dec 12, 2019
dc42520
after prettier
Janpot Dec 12, 2019
a0d43b1
add a test for listChangedFiles
Janpot Dec 12, 2019
4821a88
Merge branch 'master' into tracked-branch
Janpot Dec 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/listChangedFiles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ async function execGitCmd(args) {
}

async function listChangedFiles() {
const mergeBase = await execGitCmd(['rev-parse', 'origin/master']);
const mergeBase = await execGitCmd(['rev-parse', 'master']);
const gitDiff = await execGitCmd(['diff', '--name-only', mergeBase]);
const gitLs = await execGitCmd(['ls-files', '--others', '--exclude-standard']);
return new Set([...gitDiff, ...gitLs]);
Expand Down