[core] Lint with typescript-eslint parser #21758

oliviertassinari · 2020-07-11T20:11:27Z

This effort is part of a unification of the infrastructure that supports the authoring of outstanding React components for Material-UI between the main repository, the enterprise repository (written in TypeScript) and the pickers repository (written in TypeScript) that will likely be split between the main one for the MIT components and the x one for the enterprise features (#19706).

The objective is to find a configuration that works in the environment that sets the highest constraints (here) to then be able to copy and paste (until we find something better) the configuration to:

mui-pr-bot · 2020-07-11T20:21:36Z

Details of bundle changes

Generated by 🚫 dangerJS against d24c890

eps1lon · 2020-07-12T10:15:18Z

Heads up: We recently bumped eslint from 6 to 7 so this branch should be updated before considering to make this ready for review.

oliviertassinari · 2020-07-13T09:10:08Z

Heads up: We recently bumped eslint from 6 to 7 so this branch should be updated

I have rebased, no change in the configuration was required :).

dmtrKovalenko · 2020-07-13T09:11:34Z

.eslintrc.js

+ extends: [
+ 'plugin:import/recommended',
+ 'plugin:import/typescript',
+ 'airbnb-typescript',


What the motivation of usage predefined config? Why not to use recommended by @tpescript-eslint?

One of the end goal is to avoid developers or have to format the code once they copy and paste it from the demos. So the question we should answer to is: what's more popular in the community? Also, we have to consider that the stricter rules also cover lesser rules, meaning we can cover more developers by being more strict than the average.

The second goal is to make us more productive.

Note that we were already using the Airbnb configuration. My objective was to lint TypeScript minimizing the diff. If we want to change the rules, that would be best in a different pull request.

We can discuss the preset in another issue. This PR should be limited to switching the parser and adding TS files.

.eslintrc.js

eps1lon

Might've repeated myself but there's a lot to go through here. Big thanks to working on this 👍

.eslintignore

eps1lon · 2020-07-13T09:26:52Z

.eslintrc.js

+ extends: [
+ 'plugin:import/recommended',
+ 'plugin:import/typescript',
+ 'airbnb-typescript',


We can discuss the preset in another issue. This PR should be limited to switching the parser and adding TS files.

.eslintrc.js

eps1lon · 2020-07-13T09:27:54Z

.eslintrc.js

 rules: {
+ '@typescript-eslint/dot-notation': 'off', // Too slow


If you enable the rules that are disabled with // Too slow, you will timeout the CI. No answers after 10 minutes. It seems to get stuck. I haven't looked at why.

.eslintrc.js

packages/material-ui/src/Button/Button.spec.tsx

packages/material-ui/src/index.d.ts

packages/material-ui/src/styles/colorManipulator.js

packages/material-ui/src/styles/transitions.test.js

packages/material-ui/test/typescript/components.spec.tsx

docs/src/modules/components/TopLayoutBlog.js

I have tried to take as many feedback as possible into account

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>

dtassone · 2020-07-16T09:39:26Z

.eslintrc.js

+ 'react/destructuring-assignment': 'off', // It's fine.
+ 'react/forbid-prop-types': 'off', // Too strict, no time for that
+ 'react/jsx-curly-brace-presence': 'off', // broken
+ 'react/jsx-filename-extension': ['error', { extensions: ['.js', '.tsx'] }], // airbnb is using .jsx


why no .jsx here?

If you don't care about restricting the file extensions that may contain JSX.

-- https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md

.jsx isn't allowed, influenced by airbnb/javascript#985 (comment)

Follow-up on mui#21758 (comment)

oliviertassinari added typescript core Infrastructure work going on behind the scenes labels Jul 11, 2020

github-actions bot mentioned this pull request Jul 11, 2020

Update snapshots for pr/21758 eps1lon/mui-scripts-incubator#545

Closed

oliviertassinari force-pushed the lint-typescript branch 5 times, most recently from 5f39f8b to 935ebfb Compare July 12, 2020 01:27

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 12, 2020

oliviertassinari force-pushed the lint-typescript branch from 935ebfb to 7243c5d Compare July 12, 2020 11:27

oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 12, 2020

oliviertassinari marked this pull request as ready for review July 12, 2020 11:27

oliviertassinari force-pushed the lint-typescript branch from 7243c5d to 29f9613 Compare July 12, 2020 11:29

oliviertassinari requested review from eps1lon, dmtrKovalenko and dtassone July 12, 2020 11:34

oliviertassinari force-pushed the lint-typescript branch from faf0c05 to 5079f88 Compare July 12, 2020 13:39

dmtrKovalenko reviewed Jul 13, 2020

View reviewed changes

eps1lon previously requested changes Jul 13, 2020

View reviewed changes

eps1lon mentioned this pull request Jul 13, 2020

[Popper] Upgrade to popper.js to v2 #21761

Merged

1 task

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 14, 2020

oliviertassinari commented Jul 14, 2020

View reviewed changes

docs/src/modules/components/TopLayoutBlog.js Outdated Show resolved Hide resolved

oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 14, 2020

oliviertassinari force-pushed the lint-typescript branch from f3027d3 to fe2a906 Compare July 14, 2020 16:50

oliviertassinari requested review from dmtrKovalenko and eps1lon July 14, 2020 16:51

oliviertassinari and others added 13 commits July 16, 2020 00:36

second iteration

e9875d9

third iteration

8550e4d

polish

ab92759

Update .eslintignore

17054b7

Sebastian review

a906820

Port custom eslint plugin to typescript-eslint/parser (#8)

b065e8b

restore revious grouping

e6a9a4f

Sebastian's review

6bbda99

Disable no-use-before define as it was before (#10)

8d3b7e1

Update .eslintignore

816938e

Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>

Sebastian's review

d3af321

limit allow syntax

7cea772

try perf import/no-cycle

f34e233

oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 15, 2020

oliviertassinari force-pushed the lint-typescript branch from 40bab50 to f34e233 Compare July 15, 2020 22:37

fix CI

eed7b61

dtassone reviewed Jul 16, 2020

View reviewed changes

dtassone approved these changes Jul 16, 2020

View reviewed changes

fix ci

d24c890

oliviertassinari merged commit ee6f54e into mui:next Jul 16, 2020

oliviertassinari deleted the lint-typescript branch July 16, 2020 10:11

oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Jul 25, 2020

[core] Fix sorting

3cbc74c

Follow-up on mui#21758 (comment)

oliviertassinari mentioned this pull request Jul 25, 2020

[core] Batch small changes #21928

Merged

eps1lon mentioned this pull request Jul 28, 2020

[core] Lint cleanup #21972

Merged

oliviertassinari mentioned this pull request Aug 2, 2020

Migrate to TypeScript #15984

Closed

2 tasks

oliviertassinari mentioned this pull request Feb 8, 2021

Bump eslint-config-airbnb-typescript from 12.0.0 to 12.3.1 #24810

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Lint with typescript-eslint parser #21758

[core] Lint with typescript-eslint parser #21758

oliviertassinari commented Jul 11, 2020 •

edited

Loading

mui-pr-bot commented Jul 11, 2020 •

edited

Loading

eps1lon commented Jul 12, 2020

oliviertassinari commented Jul 13, 2020

dmtrKovalenko Jul 13, 2020

oliviertassinari Jul 13, 2020 •

edited

Loading

oliviertassinari Jul 13, 2020 •

edited

Loading

eps1lon Jul 13, 2020

eps1lon left a comment

eps1lon Jul 13, 2020

eps1lon Jul 13, 2020

oliviertassinari Jul 13, 2020 •

edited

Loading

dtassone Jul 16, 2020

eps1lon Jul 16, 2020

oliviertassinari Jul 16, 2020 •

edited

Loading

		rules: {
		'@typescript-eslint/dot-notation': 'off', // Too slow

[core] Lint with typescript-eslint parser #21758

[core] Lint with typescript-eslint parser #21758

Conversation

oliviertassinari commented Jul 11, 2020 • edited Loading

mui-pr-bot commented Jul 11, 2020 • edited Loading

eps1lon commented Jul 12, 2020

oliviertassinari commented Jul 13, 2020

dmtrKovalenko Jul 13, 2020

Choose a reason for hiding this comment

oliviertassinari Jul 13, 2020 • edited Loading

Choose a reason for hiding this comment

oliviertassinari Jul 13, 2020 • edited Loading

Choose a reason for hiding this comment

eps1lon Jul 13, 2020

Choose a reason for hiding this comment

eps1lon left a comment

Choose a reason for hiding this comment

eps1lon Jul 13, 2020

Choose a reason for hiding this comment

eps1lon Jul 13, 2020

Choose a reason for hiding this comment

oliviertassinari Jul 13, 2020 • edited Loading

Choose a reason for hiding this comment

dtassone Jul 16, 2020

Choose a reason for hiding this comment

eps1lon Jul 16, 2020

Choose a reason for hiding this comment

oliviertassinari Jul 16, 2020 • edited Loading

Choose a reason for hiding this comment

oliviertassinari commented Jul 11, 2020 •

edited

Loading

mui-pr-bot commented Jul 11, 2020 •

edited

Loading

oliviertassinari Jul 13, 2020 •

edited

Loading

oliviertassinari Jul 13, 2020 •

edited

Loading

oliviertassinari Jul 13, 2020 •

edited

Loading

oliviertassinari Jul 16, 2020 •

edited

Loading