-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint-config-airbnb-typescript from 12.0.0 to 12.3.1 #24810
Bump eslint-config-airbnb-typescript from 12.0.0 to 12.3.1 #24810
Conversation
@dependabot squash and merge |
b854364
to
c456a28
Compare
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
We have solved the issue in the x repo with: https://github.com/mui-org/material-ui-x/blob/bf4bb413b0d80a423ea3649a8b4579c434902b61/.eslintrc.js#L25 |
Let me take a look first. Seems like you just disabled this rule globally. We should never disable rules without countering their rationale. |
True, this solution wasn't necessarily the best one. From what I recall, I did the same in: To have the eslint rule take the same amount of time as before when introducing the linting of TypeScript sources #21758. |
@dependabot rebase |
Bumps [eslint-config-airbnb-typescript](https://github.com/iamturns/eslint-config-airbnb-typescript) from 12.0.0 to 12.3.1. - [Release notes](https://github.com/iamturns/eslint-config-airbnb-typescript/releases) - [Changelog](https://github.com/iamturns/eslint-config-airbnb-typescript/blob/master/CHANGELOG.md) - [Commits](iamturns/eslint-config-airbnb-typescript@v12.0.0...v12.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
c456a28
to
598f333
Compare
Bumps eslint-config-airbnb-typescript from 12.0.0 to 12.3.1.
Release notes
Sourced from eslint-config-airbnb-typescript's releases.
Commits
e9910fc
fix: Missing files in npm bundle4a9fba1
feat: Reduce package size (#193)21a3f3b
feat: Support object-curly-spacing (#192)b1125b5
fix: Invalid JSON57a3142
feat: Supportrequire-await
,no-return-await
,space-infix-ops
(#183)ae5de5b
chore(deps): update dependency @typescript-eslint/eslint-plugin to v4.14.2 (#...2daa613
chore(deps): update dependency eslint to v7.19.0 (#170)abd490d
chore(deps): update dependency lint-staged to v10.5.4 (#172)4a0b636
chore: Fix renovate JSONacd1c49
chore(deps): update dependency typescript to v4.1.3 (#174)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @eps1lon.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.yml
file in this repo: