-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Auto-fix upcoming eslint issues #34644
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@michaldudak Since this is a large PR, I'm specifically calling attention to the removal of fragment in the base demo: https://github.com/mui/material-ui/pull/34644/files#diff-036fe9f47ed568c74dc41779902387e3faf8b49a20818792e906da08a91f84e3L9. Just in case it's there for a reason |
@Janpot it seems that the demo works correctly after your change. I'm wondering, what's the rationale for disallowing components as lambdas? |
@michaldudak airbnb/javascript#2505 (comment) I also remember it at some point to be a requirement for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :)
@michaldudak Just stumbled upon it while looking for something else: https://nextjs.org/docs/basic-features/fast-refresh#limitations
|
Always good to learn something new, thanks! |
@m4theushw A heads up, the eslint configuration is going to change. If we could apply the same auto-fix cases in MUI X, it would be great. |
Running
yarn lint --fix
on #34642 without upgrading eslintTo reviewers: recommended to hide whitespace to drastically reduce the line count
edit:
this messes with the tooltip in the demos: