[docs-infra] Fix truncated TOCs scrollbar #37770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
docs-scrollbar-v2
branch
2 times, most recently
from
14131a6 to
74ae4d4
Compare
oliviertassinari
requested review from
alexfauquette
and removed request for
siriwatknp
Netlify deploy previewhttps://deploy-preview-37770--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
docs-scrollbar-v2
branch
from
74ae4d4 to
97c7cd3
Compare
oliviertassinari
added
the
design
oliviertassinari
commented
Jul 1, 2023
| @@ -11,7 +11,7 @@ tags: ['Company'] | |||
|
|
|||
| ### Image | |||
|
|
|||
| <img alt="Satellite image of Tenerife" src="/static/blog/2022-tenerife-retreat/tenerife.jpeg" style="aspect-ratio: 4/3;" loading="lazy" /> | |||
| <img alt="Satellite image of Tenerife" src="/static/blog/2022-tenerife-retreat/tenerife.jpeg" width="2560" height="1920" loading="lazy" /> | |||
There was a problem hiding this comment.
Not related to the other changes, but a quick win. This page is supposed to be the standard reference, here is the standard reference to how to include images, but this was outdated. Using the real width and height fixes the layout shift.
alexfauquette
approved these changes
Jul 3, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly noticeable on Windows, the truncated scrollbar feels confusing.
It feels like the scroll isn't at the top, so there is more things to scroll up to that his hidden, but once you try to scroll up, you realize that no, you are already at the top 🙈
Before:
https://mui.com/joy-ui/react-checkbox/
After:
https://deploy-preview-37770--material-ui.netlify.app/joy-ui/react-checkbox/